bugGNU Octave - Bugs: bug #41159, GUI various text-related minor...

 
 

bug #41159: GUI various text-related minor issues

Submitted by:  Felipe G. Nievinski <fgnievinski>
Submitted on:  Thu 09 Jan 2014 02:55:54 AM UTC  
 
Category:  GUI Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Other
Status:  None Assigned to:  None
Originator Name:  Open/Closed:  Closed
Release:  3.8.0 Operating System:  Microsoft Windows

Add a New Comment (Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

( Jump to the original submission)

Fri 10 Jan 2014 09:44:40 PM UTC, comment #15: 

Different issues of this report split up into:

bug #41201
bug #41200
bug #41197
bug #41196
bug #41195
bug #41194

Closing report

Torsten Lilge <ttl>
Project Member
Fri 10 Jan 2014 09:03:22 PM UTC, comment #14: 

pls go ahead and close this report -- it's been all split up now.

Felipe G. Nievinski <fgnievinski>
Fri 10 Jan 2014 08:01:23 PM UTC, comment #13: 

I don't know which ones need more detail.  I didn't look.

If you are going to split things up, then split the whole giant report up into separate self-contained reports that don't need to refer back to some other report and then close the original one.  Otherwise, someone looking here will have no idea which of the individual reports are closed without looking through everything in the original report.

John W. Eaton <jwe>
Project Administrator
Fri 10 Jan 2014 07:49:12 PM UTC, comment #12: 

@jwe: I thought the bug titles were self evident; which one would you like to be further detailed?

Felipe G. Nievinski <fgnievinski>
Fri 10 Jan 2014 07:46:38 PM UTC, comment #11: 

ok, these are the issue NOT split off into their own bugs (nor already resolved here) -- let me know if you'd rather have them chopped up more thinly:

strings lacking internationalization:
"%d matches"
"New File.txt"
"New Directory"
"Find and Replace" (only one of its instances)

Some uncontroversial modifications for the original texts in English -- hopefully the translations can be modified accordingly without having to call the translators:
Save File &As > Save File &As...
Print > Print...
Save Workspace As > Save Workspace As...
is already open in the editor > is already open in the editor.
Find Files ... > Find Files...
Load Workspace > Load Workspace...
Goto line > Goto line... [or Go to line...]
&More > &More...
Show octave directory > Show Octave directory
Set octave directory > Set Octave directory
Goto current octave directory > Go to current Octave directory
is a placeholder for the default background color) > is a placeholder for the default background color).
ways to get help including > ways to get help, including

Some possibly controversial modifications:
emacs > emacs +%l %f
&New File > &New Script
Enter the filename expression > Enter the filename search expression
Named: > Filename:
Start in: > Start directory:
Recurse directories > Search in sub-directories
Include directories > Include directory names
Search must match text > Enter the file content search expression
View the variables in the active workspace. > View the variables in the workspace.
storage class > category
The associated file editor tab has disappeared. It was likely closed by some means. > The associated file editor tab has disappeared.
The configuration file is stored in %1. If that file exists, you will not see this dialog when Octave starts. > The configuration file is stored in %1.

rename "Script" [in the toolbar, not in the menu] to "New Script"

In the File Browser, rename "Search diretory" to "Set directory" (that's what it actually does)
also replace its icon, from a magnifying glass to a folder icon.
then use the magnifying glass for the Find Files

Felipe G. Nievinski <fgnievinski>
Fri 10 Jan 2014 07:44:52 PM UTC, comment #10: 

How about, when you split the bug report up, you actually include enough information in the new report to make it self contained, so that it doesn't have to refer to the old giant bug report?  Otherwise, I don't see the point of splitting it up.

John W. Eaton <jwe>
Project Administrator
Fri 10 Jan 2014 07:29:00 PM UTC, comment #9: 

will do

Felipe G. Nievinski <fgnievinski>
Fri 10 Jan 2014 07:21:28 PM UTC, comment #8: 

We definitely should start to separate this bug report into several ones. Comment #7, comment #5, resizing the settings dialog, and the find in selection feature are not text only issues.

Torsten Lilge <ttl>
Project Member
Fri 10 Jan 2014 06:49:01 PM UTC, comment #7: 

here's another one: the Workspace dock shouldn't show internal variables (those prefixed with double underscore, __).

Felipe G. Nievinski <fgnievinski>
Fri 10 Jan 2014 05:13:45 PM UTC, comment #6: 

Reply to comment #4:
We had a discussion about this in the maintainers list and the result was that it can be useful to browse files without changing the octave directory. If a synchronization between the two directories is desired the preference can be set accordingly.

Torsten Lilge <ttl>
Project Member
Fri 10 Jan 2014 03:26:56 AM UTC, comment #5: 

this is a feature request (should I file it as a separate bug?)
the editor could highlight invalid characters. 
for example, "á" in the first line (but not in the second one:

variável = pi
var = pi  % variável

Felipe G. Nievinski <fgnievinski>
Fri 10 Jan 2014 12:59:25 AM UTC, comment #4: 

I think the file browser directory and the octave directory should be always synchronized; the alternative would be confusing, not least for ex-matlab users, where that's the behavior (I've just checked).

Felipe G. Nievinski <fgnievinski>
Thu 09 Jan 2014 08:57:34 PM UTC, comment #3: 

Changeset
http://hg.savannah.gnu.org/hgweb/octave/rev/0b5f669f5b03
fixes:

  • comments for "b", "i", "u"
  • comments and missing newlines in "Create file/folder in"
  • translations of the news message ("not connected" and "disabled")
Torsten Lilge <ttl>
Project Member
Thu 09 Jan 2014 06:32:03 PM UTC, comment #2: 

you're right, it says "1 matches".
maybe this line:
  QString res_str = QString ("%1 matches").arg (m->rowCount ());
can be internationalized as follows:
  QString res_str = QString (tr ("%n matches", 0, m->rowCount ()));
as per <http://qt-project.org/doc/qt-4.8/i18n-source-translation.html#handling-plurals>

Felipe G. Nievinski <fgnievinski>
Thu 09 Jan 2014 05:54:46 PM UTC, comment #1: 

Here some comments:

The "Search in Selection" feature was only recently added in QScintilla and just has not been implemented in octave.

GUI File Browser "Show/Set octave directory" is always disabled only if the file browser directory and the octave directory is synchronized.

On windows, the qt-translation files (including those for qscintilla) are missing (bug #39455).

I am going to fix the other issues step by step (mh, I do not find "%d match" or "%1 match" in the sources).

Torsten Lilge <ttl>
Project Member
Thu 09 Jan 2014 02:55:54 AM UTC, original submission:  

GUI Editor Search & Replace "Search [in] selection" checkbox is always disabled, even if some text is selected

GUI File Browser "Show/Set octave directory" is always disabled

GUI Preferences should resize automatically to fit contents
(translated texts are more verbose and are being truncated)

Find File window button focus should be on Search not Browse
(so that hitting Enter at the "Named:" field runs the search.)

GUI Preferences Editor Styles keywords are not internationalized
(keywords such as "Default", "Comment", "Command", etc.)

GUI Preferences Editor Styles b,i,u (for bold, italic, underline) need some context comments in the source code for helping the translators

similar context comments for tr ("Create file in\n"), about the newline

Other strings lacking internationalization:
"%d match"
"%d matches"
"New File.txt"
"New Directory"
"Find and Replace" (only one of its instances)
"Connecting to the web to display the latest Octave Community news has been disabled."

Some uncontroversial modifications for the original texts in English -- hopefully the translations can be modified accordingly without having to call the translators:
Save File &As > Save File &As...
Print > Print...
Save Workspace As > Save Workspace As...
is already open in the editor > is already open in the editor.
Find Files ... > Find Files...
Load Workspace > Load Workspace...
Goto line > Goto line... [or Go to line...]
&More > &More...
Show octave directory > Show Octave directory
Set octave directory > Set Octave directory
Goto current octave directory > Go to current Octave directory
is a placeholder for the default background color) > is a placeholder for the default background color).
ways to get help including > ways to get help, including

Some possibly controversial modifications:
emacs > emacs +%l %f
&New File > &New Script
Enter the filename expression > Enter the filename search expression
Named: > Filename:
Start in: > Start directory:
Recurse directories > Search in sub-directories
Include directories > Include directory names
Search must match text > Enter the file content search expression
View the variables in the active workspace. > View the variables in the workspace.
storage class > category
The associated file editor tab has disappeared.  It was likely closed by some means. > The associated file editor tab has disappeared.
The configuration file is stored in %1.  If that file exists, you will not see this dialog when Octave starts. > The configuration file is stored in %1.

rename "Script" [in the toolbar, not in the menu] to "New Script"

In the File Browser, rename "Search diretory" to "Set directory" (that's what it actually does)
also replace its icon, from a magnifying glass to a folder icon.
then use the magnifying glass for the Find Files

Felipe G. Nievinski <fgnievinski>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by jwe (Posted a comment)
  • -email is unavailable- added by ttl (Posted a comment)
  • -email is unavailable- added by fgnievinski (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

     

     

    Follows 1 latest change.

    Date Changed by Updated Field Previous Value => Replaced by
    2014-01-10 ttl Open/ClosedOpen => Closed

    Back to the top


    Powered by Savane 3.5