patchGNU Octave - Patches: patch #9809, Image package, cp2tform...

 
 

patch #9809: Image package, cp2tform documentation

Submitted by:  Evangelos Rozos <vrozos>
Submitted on:  Mon 27 May 2019 01:28:50 PM UTC  
 
Category:  Forge : other Priority:  5 - Normal
Status:  None Privacy:  Public
Assigned to:  None Open/Closed:  Closed

Add a New Comment (Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sat 15 Jun 2019 03:50:02 PM UTC, comment #2: 

Closing this item, since
https://savannah.gnu.org/bugs/index.php?56492 has been opened

Avinoam Kalma <avinoam>
Project Member
Thu 30 May 2019 03:47:16 AM UTC, comment #1: 

Thanks for reporting.
I will prepare a changeset.

Avinoam Kalma <avinoam>
Project Member
Mon 27 May 2019 01:28:50 PM UTC, original submission:  

The documentation of cp2tform (https://octave.sourceforge.io/image/function/cp2tform.html) has some errors.

In the affine transformation the following lines

in_cp = [out_cp ones(rows (out_cp,1))] * Tinv

out_cp = [in_cp ones(rows (in_cp,1))] * T

have two errors: i) 'rows' function takes only one argument, and ii) 'ones' function takes two arguments. Furthermore, it would be more clear to replace Tinv and T with the full path. That is:

in_cp =  [out_cp ones(rows (out_cp) ,1)] * T.tdata.Tinv

out_cp=  [in_cp ones(rows (in_cp) ,1)] * T.tdata.T

The same problems exist in the projective transformation.

Also, Tinv should be replaced with the full path (i.e. T.tdata.Tinv) in the polynomial transformation too.

Evangelos Rozos <vrozos>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by avinoam (Posted a comment)
  • -email is unavailable- added by avinoam
  • -email is unavailable- added by avinoam
  • -email is unavailable- added by vrozos (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

     

     

    Follow 3 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2019-06-15 avinoam Open/ClosedOpen => Closed
    2019-05-30 avinoam Carbon-Copy- => Added carandraug
        Carbon-Copy- => Added hardy

    Back to the top


    Powered by Savane 3.5