bugGNU Octave - Bugs: bug #56492, [octave forge] (image)...

 
 

bug #56492: [octave forge] (image) improvements to documentation of cp2tform

Submitter:  Hartmut <hardy>
Submitted:  Thu 13 Jun 2019 06:47:55 PM UTC
   
 
Category:  Octave Package Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Documentation
Status:  Fixed Assigned to:  None
Originator Name:  Open/Closed:  * Closed
Release:  * dev Operating System:  * Any
Fixed Release:  None Planned Release:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Jump to the original submission

Tue 02 Jul 2019 03:37:50 AM UTC, comment #6: 

Thanks, looks good.
Closing.

Avinoam Kalma <avinoam>
Group Member
Mon 01 Jul 2019 06:22:45 AM UTC, comment #5: 

Thanks for the hints.

  • I have now merged the stable branch to default. I hope all went well, otherwise let me know, please.
  • I intentionally pushed this little changeset to the stable branch, because it only fixes documentation texts.
Hartmut <hardy>
Sun 30 Jun 2019 08:25:46 PM UTC, comment #4: 

Thanks for pushing this. You should also merge stable to default.

BTW, if I understand correctly from Carne (and maybe I'm not),
the stable branch should be used for regressions, and not for general bug fixes.
See for example bug #55780.

Avinoam Kalma <avinoam>
Group Member
Sun 30 Jun 2019 03:40:28 PM UTC, comment #3: 

I have now pushed Pantxo's patch (from comment #1) unchanged to the stable branch of the image repo:

   http://hg.code.sf.net/p/octave/image/rev/52a21f2a573e

Thanks again for this fast fix! It should appear in the next bug-fix release of the image package (probably version 2.10.1.)

@Avinoam: Could you please have a close look if my very first mercurial "push" went all well? You could also then close this bug report, thanks.

Hartmut <hardy>
Fri 14 Jun 2019 06:30:17 PM UTC, comment #2: 

Thanks for this fast patch to "your" function cp2tform, Pantxo. I have had a look at the patch and think it fully "fixes" this issue.

If you give me some (weeks) time, I would like to push this patch on my own to the image repo, in order to "initialise" my new push rights. Thanks.

Hartmut <hardy>
Fri 14 Jun 2019 12:53:33 PM UTC, comment #1: 

I attached a patch that does the proposed changes.

(file #47098)

Pantxo Diribarne <pantxo>
Group Member
Thu 13 Jun 2019 06:47:55 PM UTC, original submission:  

There were some suggestions to improve the documentation of cp2tform on the mailing list. I will copy this to here in order to not forget it:


The documentation of cp2tform
(https://octave.sourceforge.io/image/function/cp2tform.html) has some
errors.

In the affine transformation the following lines

in_cp = [out_cp ones(rows (out_cp,1))] * Tinv

out_cp = [in_cp ones(rows (in_cp,1))] * T

have two errors: i) 'rows' function takes only one argument, and ii)
'ones' function takes two arguments. Furthermore, it would be more clear
to replace Tinv and T with the full path. That is:

in_cp =  [out_cp ones(rows (out_cp) ,1)] * T.tdata.Tinv

out_cp=  [in_cp ones(rows (in_cp) ,1)] * T.tdata.T

The same problems exist in the projective transformation.

Also, Tinv should be replaced with the full path (i.e. T.tdata.Tinv) in
the polynomial transformation too.

Regards

Evangelos Rozos


source: http://octave.1599824.n4.nabble.com/Image-package-cp2tform-documentation-td4692963.html#a4692964

Hartmut <hardy>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #47098:  doc_cp2tform.patch added by pantxo (2KiB - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by avinoam (Posted a comment)
  • -email is unavailable- added by pantxo (Updated the item)
  • -email is unavailable- added by hardy (Submitted the item)
  • -email is unavailable- added by hardy
  • -email is unavailable- added by hardy
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only group members can vote.

     

    Follow 6 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2019-07-02 avinoam Open/ClosedOpen Closed
    2019-06-30 avinoam StatusPatch Submitted Fixed
    2019-06-14 pantxo Attached File- Added doc_cp2tform.patch, #47098
        StatusNone Patch Submitted
    2019-06-13 hardy Carbon-Copy- Added avinoam
        Carbon-Copy- Added carandraug

    Back to the top

    Powered by Savane 3.13-f8d8.
    Corresponding source code