I have pushed this now.

Thanks for the reviews (comment #11 & comment #12).
I will prepare a revised version

I have had a look at the new file version (V3):

• my issues from comment #8 seem to be fixed (there doesn't seem to be any trouble with imcast...)
• Are all those tests Matlab compatible? (I have not checked this.)
• The following (Matlab compatible) input classes are currently not tested: int64, uint32, uint64. Do they work? (then let's test them) Or dont' they work for a good reason?(then let's document this in the help string). My short testing showed that they seem to work well, if that's true then please just add a test for each possible input class.

Thanks for the review.
I will fix these comments, and send another patch for review.

Please review

Could you also confirm whether Matlab requires a column or array vector? And what happens if you pass a matrix? Would be nice to pass a matrix, one histogram per column, and get back an array of threshold values. This would allow to threshold an array of images in one go.

I have made some changes to it:

https://bitbucket.org/carandraug/octave-image/commits/1664caa6b2729a50adb47700cbbdf9bb8194f522

When it comes to tests, since the point of this function is to use on processed histograms and to control the number of bins, can you use histograms that are not already used in the graythresh? Things like histograms with 10 bins, all bins with a value of zero, an histogram of length 0 and one, an histogram with values of class integer, an histogram with an Inf, etc?

At the moment, Octave comes with penny.mat which could be used for testing purposes and is very unlikely to change.

Thanks for your contribution!

I've had a look at this new function:

• This is a wrapper around the already existing functionality of Otsu's threshhold in Octave's graythresh function. So any wrong output values wouldn't be due to this new otsuthresh function anyways. But it would still be nice to have the outputs Matlab compatible. I have not checked the results of the included tests in Matlab, have you? Do they give the same results in Matlab?

• The included tests all pass.

• Nice demo included :)

• I have tested the example from the Matlab documentation (http://de.mathworks.com/help/images/ref/otsuthresh.html). It gives the same result with this new otsuthresh.m function. (I needed to use im2bw.m instead of the new imbinarize.m to make the example run under Octave.)

(general remark: It would help to have some simple image files distributed along with the image package. Those could be used for tests and demos more easily. Or are there already some of those, in addition to phantom.m, that I just don't know of?)

I would like to see this new function added to the image package. (To keep up with Matlab changes, this was only introduced in R2016a...)