(
Jump to the original submission)
Tue 28 Nov 2017 08:20:20 PM UTC, comment #11:
Reopening this bug, because of comment #9 and comment #10 that should be fixed.
|
Tue 06 Jun 2017 08:46:26 PM UTC, comment #10:
There is another problem with graythresh:
running the tests with Otsu in Matlab, the thresh is 114.5, and not 115, so the test should be:
To get Matlab results, the "ceil" in line 235 should be removed.
|
Mon 05 Jun 2017 09:10:33 PM UTC, comment #9:
There is still a minor problem in a corner case:
In Matlab the answer is zero.
The problem is in the line:
thresh{1} = double (thresh{1}) / (numel (ihist) - 1);
since numel(ihist) is 1
|
Sun 23 Apr 2017 08:34:40 PM UTC, comment #8:
Done http://hg.code.sf.net/p/octave/image/rev/37e9f3f3e1c8
|
Sun 23 Apr 2017 06:00:22 PM UTC, comment #7:
Another typo:
img_max = 65535 in line 171, but img_max is not used elsewhere.
|
Wed 12 Apr 2017 04:41:25 PM UTC, comment #6:
> It seems that few semicolons have disappeared.
Ups. I put them back now
http://hg.code.sf.net/p/octave/image/rev/382986039e12
|
Wed 12 Apr 2017 02:13:55 PM UTC, comment #5:
@Carnë: Thanks for the fix.
It seems that few semicolons have disappeared.
|
Wed 12 Apr 2017 01:27:33 PM UTC, comment #4:
I am not sure why you were using `!isfinite` when the problem is that `max (bcv)` returned NaN. I used isnan which is clearer. Also, I put the check earlier and avoided computing threshold and goodness in such case.
http://hg.code.sf.net/p/octave/image/rev/34c55ccd6dad
|
Thu 08 Dec 2016 05:36:22 PM UTC, comment #3:
@Carnë:
Please review the cs in comment #2
|
Wed 19 Aug 2015 08:20:56 AM UTC, comment #2:
cs attached. Please review
(file #34676)
|
Wed 17 Jun 2015 05:57:42 AM UTC, comment #1:
The correction should be something like
near the end of function otsu
|
Tue 16 Jun 2015 06:10:56 PM UTC, original submission:
Example:
For Matlab compatibility, such corner case should return a value of zero.
|
(Note: upload size limit is set to 16384 kB, after insertion of the required
escape characters.)
Attach File(s):
Comment:
Depends on the following items: None found
Items that depend on this one: None found
Follow 7 latest changes.