GNU Octave - Tasks: task #14243, Rewrite legend.m
You are not allowed to post comments on this tracker with your current authentication level.
task #14243: Rewrite legend.m
Submitter: | Pantxo Diribarne <pantxo> | ||
Submitted: | Thu 17 Nov 2016 10:11:23 AM UTC | ||
Votes: | 2 | ||
Should Start On: | Thu 17 Nov 2016 12:00:00 AM UTC | Should be Finished on: | Thu 17 Nov 2016 12:00:00 AM UTC |
Category: | Wish | Priority: | 5 - Normal |
Status: | Done | Privacy: | Public |
Assigned to: | None | Originator Name: | |
Open/Closed: | Closed | Fixed Release: | None |
Planned Release: | None |
Jump to the original submission
Mon 18 Nov 2019 09:20:49 PM UTC, comment #25: |
Philip Nienhuis <philipnienhuis> |
Mon 18 Nov 2019 07:14:57 PM UTC, comment #24: @Philip: Thanks.
|
Pantxo Diribarne <pantxo> |
Mon 18 Nov 2019 07:02:35 PM UTC, comment #23: By the way: an impressive piece of work, Panxto, thank you very much! |
Philip Nienhuis <philipnienhuis> |
Mon 18 Nov 2019 07:01:38 PM UTC, comment #22: Q: (haven't built yet)
|
Philip Nienhuis <philipnienhuis> |
Mon 18 Nov 2019 09:53:18 AM UTC, comment #21: @Rik: Thanks. I fixed the latest reported issues, improved the autoupdate code, and pushed the patch here:
|
Pantxo Diribarne <pantxo> |
Thu 14 Nov 2019 06:30:42 PM UTC, comment #20: I think this is very close to having sufficient functionality that you can check the code in and we can continue development through ordinary bug reports as any problems are found.
|
Rik <rik5> |
Wed 13 Nov 2019 08:58:54 AM UTC, comment #19: I attached an updated cset that improves performances a bit and fixes a bunch problems. |
Pantxo Diribarne <pantxo> |
Tue 12 Nov 2019 04:35:53 PM UTC, comment #18: I came to the same conclusion about _appdata_ being a different issue and filed bug #57212 to track it.
|
Rik <rik5> |
Tue 12 Nov 2019 04:17:55 PM UTC, comment #17: Looks like the zip archive is too large. |
Pantxo Diribarne <pantxo> |
Tue 12 Nov 2019 04:13:43 PM UTC, comment #16: Trying again to attach |
Pantxo Diribarne <pantxo> |
Tue 12 Nov 2019 04:11:41 PM UTC, comment #15: I attached a figure that shows the performance drop when plotting and printing legend demos. In lies between 20% (most often) and more than 100% in some cases.
|
Pantxo Diribarne <pantxo> |
Tue 12 Nov 2019 11:56:57 AM UTC, comment #14: @Rik: Here is an updated patch.
|
Pantxo Diribarne <pantxo> |
Tue 12 Nov 2019 12:17:50 AM UTC, comment #13: I'm starting to recall that legend is a very intricate function with lots of small behavior deviations. The good news is that the second patch is much faster, and about the same timing as what we have today when used on ordinary plots.
|
Rik <rik5> |
Mon 11 Nov 2019 06:03:11 PM UTC, comment #12: @Rik: Thanks for the review. I attached an updated version that fixes item 3 through 6, still WIP.
|
Pantxo Diribarne <pantxo> |
Sun 10 Nov 2019 03:45:22 AM UTC, comment #11: If this gets checked in you should be able to close a large number of bug reports that all relate to legend not adjusting in size correctly with changes in the axes and figure. I just came across another one: bug #56972. |
Rik <rik5> |
Sun 10 Nov 2019 02:44:12 AM UTC, comment #10: @Pantxo: I reviewed the code a bit (not fully). It's quite good in that it solves the longstanding issue where the legend position was not updated with size changes to the axes. For example,
|
Rik <rik5> |
Mon 28 Oct 2019 05:15:45 PM UTC, comment #9: I forgot to mention the ugly hack ... since I know nothing about gnuplot, I renamed the old legend.m code to _gnuplot_legend_.m and call this function when gnuplot is the graphics toolkit. |
Pantxo Diribarne <pantxo> |
Mon 28 Oct 2019 05:10:55 PM UTC, comment #8: I attached a WIP ersion of a complete rewrite of legend.m. Could you give me some feedback.
|
Pantxo Diribarne <pantxo> |
Tue 26 Dec 2017 11:58:06 PM UTC, comment #7: I eliminated the questionable use of the "userdata" property to hold internally private legend data in this cset (http://hg.savannah.gnu.org/hgweb/octave/rev/19d63669d174). |
Rik <rik5> |
Spam posted by sebald | |
Thu 21 Dec 2017 12:21:48 PM UTC, comment #5: Not that it is relevant for this task, but I significantly rewrote legend.m for greater Matlab compatibility in this cset (http://hg.savannah.gnu.org/hgweb/octave/rev/436deae9f9ab).
|
Rik <rik5> |
Wed 13 Dec 2017 08:15:07 PM UTC, comment #4: Investigating bug #52641 led me to look more closely at legend.m. My suggestion is to make this more listener/callback oriented and get rid of some of the old-convention techniques like persistent variables, etc. If one gets in the listener/callback frame of mind it becomes much easier to realize simpler ways of doing things.
|
Dan Sebald <sebald> |
Wed 23 Nov 2016 11:03:45 AM UTC, comment #3: Here are a few other tests inspired by the current demos
|
Pantxo Diribarne <pantxo> |
Thu 17 Nov 2016 09:53:54 PM UTC, comment #2: I think bug #49446 boils down to implementing the selection tool in Qt/Fltk toolkits but indeed legend objects should be able to handle custom positioning properly.
|
Pantxo Diribarne <pantxo> |
Thu 17 Nov 2016 06:59:06 PM UTC, comment #1: Can bug #49446 added to the list, please? (at least for legends) |
Philip Nienhuis <philipnienhuis> |
Thu 17 Nov 2016 10:11:23 AM UTC, original submission:
There are a couple of bug reports (that partly overlap) that show the need for (complete?) rewrite of legend.m:
|
Pantxo Diribarne <pantxo> |
Items that depend on this one: None found
There are 2 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 17 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2022-06-29 | pantxo | Status | Ready For Test | Done | |
Open/Closed | Open | Closed | |||
2019-11-18 | pantxo | Status | In Progress | Ready For Test | |
2019-11-13 | pantxo | Attached File | - | Added task14243_legend_4.patch, #47857 | |
2019-11-12 | pantxo | Attached File | - | Added oldlegend.zip, #47844 | |
Attached File | - | Added compare_plot_demos_04.html, #47845 | |||
Attached File | - | Added newlegend.zip, #47846 | |||
Attached File | - | Added compare_plot_demos_05.html, #47847 | |||
2019-11-12 | pantxo | Attached File | - | Added timings.png, #47843 | |
2019-11-12 | pantxo | Attached File | - | Added task14243_legend_3.patch, #47841 | |
2019-11-11 | pantxo | Attached File | - | Added task14243_legend_2.patch, #47838 | |
2019-11-10 | rik5 | Category | None | Wish | |
Status | None | In Progress | |||
2019-10-28 | pantxo | Attached File | - | Added task#14243_legend.patch, #47760 | |
2017-02-08 | johasixt | Carbon-Copy | - | Added johasixt | |
2016-11-30 | reginalduck | Carbon-Copy | - | Added reginalduck | |
2016-11-18 | siko1056 | Dependencies | - | Depends on bugs #40333 |
Powered by Savane 3.13-4448.
Corresponding source code
Just got a build on Linux ready. AFAICS stretching of the legend when resizing plot windows is no more - good!