taskGNU Octave - Tasks: task #11311, limits checking for property values

 
 

You are not allowed to post comments on this tracker with your current authentication level.

task #11311: limits checking for property values

Submitted by:  Ben Abbott <bpabbott>
Submitted on:  Thu 01 Sep 2011 06:20:03 PM UTC  
 
Should Start On:  Thu 01 Sep 2011 04:00:00 AM UTC Should be Finished on:  Wed 01 Sep 2021 04:00:00 AM UTC
Category:  Wish Priority:  5 - Normal
Status:  Done Privacy:  Public
Assigned to:  None Originator Name:  Ben Abbott
Open/Closed:  Closed Fixed Release:  None
Planned Release:  None

Sun 27 Nov 2016 08:14:56 PM UTC, comment #4: 

Many thanks Markus, good news this patch won't be sleeping here forever. I pushed it with a slight modification: now "error" throws an exception, the return statements after error calls are not needed anymore.

http://hg.savannah.gnu.org/hgweb/octave/rev/96228c17a66a

Closing task.

Pantxo Diribarne <pantxo>
Project Member
Fri 25 Nov 2016 06:36:17 PM UTC, comment #3: 

I took the liberty to re-base the patch to a current top and add some more constraints (and removed the one on the axes property "cameraviewangle" since this would cause a Matlab incompatibility).
Credits should still go to Pantxo because the major work was done by him.

(file #39073)

Markus M├╝tzel <mmuetzel>
Project Member
Tue 19 Jul 2016 06:08:46 PM UTC, comment #2: 

Patch doesn't apply cleanly anymore on dev tree (hg id ef91e43f162a "set DLL directory")

Philip Nienhuis <philipnienhuis>
Project Member
Sun 03 May 2015 05:43:12 PM UTC, comment #1: 

Hi,

I attached a patch that adds input validation for double_property such as those cited in the original task description. It also adds methods to check handle_property such as "uicontextmenu" that currently can be affected any graphics handle.

(file #33886)

Pantxo Diribarne <pantxo>
Project Member
Thu 01 Sep 2011 06:20:03 PM UTC, original submission:  

Octave allows properties, like linewidth and fontsize, to be set using negative values.

I'd like to suggest that limits checking be added for properties with numeric values.

Ben Abbott <bpabbott>
Project Member

 

Attached Files
file #39073:  task_11311_add_constraints_v2.patch added by mmuetzel (11KiB - application/octet-stream)
file #33886:  add_constraints.patch added by pantxo (12KiB - text/x-diff)

 

Carbon-Copy List
  • -email is unavailable- added by mmuetzel (Updated the item)
  • -email is unavailable- added by mmuetzel
  • -email is unavailable- added by pantxo (Updated the item)
  • -email is unavailable- added by bpabbott (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

     

     

    Follow 8 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2016-11-27 pantxo StatusIn Progress => Done
        Open/ClosedOpen => Closed
    2016-11-25 mmuetzel Attached File- => Added task_11311_add_constraints_v2.patch, #39073
        Carbon-Copy- => Added philipnienhuis
    2016-08-31 mtmiller Dependencies- => bugs #48961 is dependent
    2016-07-12 mtmiller Dependencies- => bugs #48469 is dependent
    2015-05-03 pantxo Attached File- => Added add_constraints.patch, #33886
        StatusNone => In Progress

    Back to the top


    Powered by Savane 3.5