taskGNU Octave - Tasks: task #11311, limits checking for property values

 
 

You are not allowed to post comments on this tracker with your current authentification level.

task #11311: limits checking for property values

Submitted by:  Ben Abbott <bpabbott>
Submitted on:  Thu Sep 1 18:20:03 2011  
 
Should Start On: Thu Sep 1 04:00:00 2011Should be Finished on: Wed Sep 1 04:00:00 2021
Category: WishPriority: 5 - Normal
Status: DonePrivacy: Public
Assigned to: NoneOriginator Name: Ben Abbott
Open/Closed: ClosedFixed Release: None
Planned Release: None

Sun Nov 27 20:14:56 2016, comment #4:

Many thanks Markus, good news this patch won't be sleeping here forever. I pushed it with a slight modification: now "error" throws an exception, the return statements after error calls are not needed anymore.

http://hg.savannah.gnu.org/hgweb/octave/rev/96228c17a66a

Closing task.

Pantxo Diribarne <pantxo>
Project Member
Fri Nov 25 18:36:17 2016, comment #3:

I took the liberty to re-base the patch to a current top and add some more constraints (and removed the one on the axes property "cameraviewangle" since this would cause a Matlab incompatibility).
Credits should still go to Pantxo because the major work was done by him.

(file #39073)

Markus M├╝tzel <mmuetzel>
Project Member
Tue Jul 19 18:08:46 2016, comment #2:

Patch doesn't apply cleanly anymore on dev tree (hg id ef91e43f162a "set DLL directory")

Philip Nienhuis <philipnienhuis>
Project Member
Sun May 3 17:43:12 2015, comment #1:

Hi,

I attached a patch that adds input validation for double_property such as those cited in the original task description. It also adds methods to check handle_property such as "uicontextmenu" that currently can be affected any graphics handle.

(file #33886)

Pantxo Diribarne <pantxo>
Project Member
Thu Sep 1 18:20:03 2011, original submission:

Octave allows properties, like linewidth and fontsize, to be set using negative values.

I'd like to suggest that limits checking be added for properties with numeric values.

Ben Abbott <bpabbott>
Project Member

 

Attached Files
file #39073:  task_11311_add_constraints_v2.patch added by mmuetzel (11kB - application/octet-stream)
file #33886:  add_constraints.patch added by pantxo (12kB - text/x-diff)

 

Depends on the following items: None found

Digest:
   bug dependencies.

 

Carbon-Copy List
  • -unavailable- added by mmuetzel (Updated the item)
  • -unavailable- added by mmuetzel
  • -unavailable- added by pantxo (Updated the item)
  • -unavailable- added by bpabbott (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 6 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sun Nov 27 20:14:56 2016pantxoStatusIn Progress=>Done
      Open/ClosedOpen=>Closed
    Fri Nov 25 18:36:17 2016mmuetzelAttached File-=>Added task_11311_add_constraints_v2.patch, #39073
      Carbon-Copy-=>Added philipnienhuis
    Sun May 3 17:43:12 2015pantxoAttached File-=>Added add_constraints.patch, #33886
      StatusNone=>In Progress

    Back to the top


    Powered by Savane 3.1-cleanup