patchGNU Octave - Patches: patch #9073, gcc 4.8 patch for compilation...

 
 

patch #9073: gcc 4.8 patch for compilation warnings and recursive infinite loop issues

Submitter:  None
Submitted:  Sun 07 Aug 2016 09:11:42 AM UTC
   
 
Category:  Core : new feature Priority:  5 - Normal
Status:  Wont Do Privacy:  Public
Assigned to:  None Originator Email:  -email is unavailable-
Open/Closed:  Closed
* Mandatory Fields

Add a New Comment Rich Markup
   

Wed 10 Aug 2016 03:41:29 PM UTC, comment #5: 

Collision :)

Anyway I think it's better to report a bug if there are specific build errors happening with these remaining points.

Mike Miller <mtmiller>
Group Member
Wed 10 Aug 2016 03:40:32 PM UTC, comment #4: 

This patch should not be necessary. The shadowing warnings are false positives in older versions of gcc and won't be fixed.

The #define in the bison source should not be necessary, the %define api.prefix declaration takes care of that. If it doesn't please report a bug about that with details.

I'm not sure what the changes to octave_exit_exception are support to accomplish. What is the point of adding a default constructor that is never used? What is the point of moving the member variable initializations into the body of the constructor? If these cause specific problems with your compiler, please report a bug about that with details.

Mike Miller <mtmiller>
Group Member
Wed 10 Aug 2016 03:36:50 PM UTC, comment #3: 

I don't want to modify the argument names to avoid -Wshadow warnings.  GCC 5 and later gets this right.  Instead, I checked in a change to disable -Wshadow if GCC 4 is detected:

http://hg.savannah.gnu.org/hgweb/octave/rev/60faa7c85e31

Does that also avoid the warnings for you?

What part of which patch fixes the recursive build loop?  Exactly what the problem you are seeing?

John W. Eaton <jwe>
Group administrator
Wed 10 Aug 2016 03:22:18 PM UTC, comment #2: 

Hello Carne
My attached hg diff fixes the build warnings issue and a recursive build loop on my gcc 4.8 / Make inifinite loop on this Linux system.

Ofcourse I cannot fix the RAM issue :D
Thanks

Anonymous
Sun 07 Aug 2016 04:13:29 PM UTC, comment #1: 

These are two separate issues, I believe:

0. gcc wanings about shadowing member functions.  That is a duplicate of bug #48493 which has been closed as won't fix. Recent versions of gcc will no longer give warnings for those (it still warns for many other shadowing, just not for local variables shadowing member functions)

0. failing to build with 512 MB. How does your patch fixes that?

Carnë Draug <carandraug>
Group Member
Sun 07 Aug 2016 09:11:42 AM UTC, original submission:  

I found some issues during building Octave (HG tip) using GCC 4.8; the compiler failed with RAM of 512 MB, and complained about a few issues of constructor/function argument shadowing member functions. To configure the build I followed the recommended bootstrap, configure and make instructions without any special flags.
 
Is this a known issue or am I doing something wrong ? Fixing these I was able to make the build successful. My patch follows in post-script. Would there be general interest to accept these changes ?

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #38167:  compiler_warning_gcc4_8.diff added by None (4KiB - application/octet-stream)
file #38131:  patch0.txt added by None (3KiB - text/plain)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by mtmiller (Posted a comment)
  • -email is unavailable- added by jwe (Posted a comment)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2016-08-10 mtmiller StatusNone Wont Do
        Open/ClosedOpen Closed
    2016-08-10 None Attached File- Added compiler_warning_gcc4_8.diff, #38167
    2016-08-07 None Attached File- Added patch0.txt, #38131

    Back to the top

    Powered by Savane 3.13-bb6a.
    Corresponding source code