patchGNU Octave - Patches: patch #9583, [Octave Forge] (signal) new...

 
 

patch #9583: [Octave Forge] (signal) new function db2mag: Convert decibels to magnitude

Submitted by:  P Sudeepam <sudeepam>
Submitted on:  Sat 10 Mar 2018 09:32:36 PM UTC  
 
Category:  Forge : new function Priority:  5 - Normal
Status:  Wont Do Privacy:  Public
Assigned to:  None Open/Closed:  Closed

Add a New Comment (Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Mon 12 Mar 2018 05:57:16 PM UTC, comment #2: 

Thankyou Mike. I have tried to adhere more strictly to the Octave style guide in my new patches please try to provide suggestions on them too. Also, the information on https://wiki.octave.org/Signal_package seems to be misguiding. I tried implementing db2mag and mag2db, only because this page says that these functions are a part of the Signals package and have not been implemented yet.

P Sudeepam <sudeepam>
Sat 10 Mar 2018 09:59:23 PM UTC, comment #1: 

The functions db2mag and mag2db are already part of the Octave control package, no need to implement these again in the signal package.

But I have read your patch. As a general suggestion, if you want to contribute further patches to Octave and Octave Forge, you should study the Octave coding style (https://wiki.octave.org/Octave_style_guide).

Mike Miller <mtmiller>
Project Administrator
Sat 10 Mar 2018 09:32:36 PM UTC, original submission:  
P Sudeepam <sudeepam>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #43508:  db2mag.patch added by sudeepam (975B - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by mtmiller (Posted a comment)
  • -email is unavailable- added by sudeepam (Submitted the item)
  • -email is unavailable- added by sudeepam
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

     

     

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2018-03-10 mtmiller StatusNone => Wont Do
        Open/ClosedOpen => Closed
    2018-03-10 sudeepam Attached File- => Added db2mag.patch, #43508
        Carbon-Copy- => Added sudeepam.pandey@gmail.com

    Back to the top


    Powered by Savane 3.5