patchGNU Octave - Patches: patch #9244, image package: regionprops.m - new...


patch #9244: image package: regionprops.m - new properties ConvexHull, ConvexImage, ConvexArea, Solidity

Submitter:  Hartmut <hardy>
Submitted:  Mon 30 Jan 2017 11:35:20 PM UTC
Category:  Forge : new feature Priority:  5 - Normal
Status:  Done Privacy:  Public
Assigned to:  None Open/Closed:  Closed
* Mandatory Fields

Add a New Comment Rich Markup

Jump to the original submission

Mon 12 Nov 2018 05:56:00 AM UTC, comment #9: 

Of course. Thanks.

Avinoam Kalma <avinoam>
Group Member
Mon 12 Nov 2018 01:51:55 AM UTC, comment #8: 

In future commits, please ensure you include the patch/bug number in the commit message.

Carnë Draug <carandraug>
Group Member
Sun 11 Nov 2018 09:54:41 PM UTC, comment #7: 
Avinoam Kalma <avinoam>
Group Member
Fri 09 Nov 2018 10:03:44 PM UTC, comment #6: 

I have had a close look at Avinoams m-file (V2) from comment #5. It contains the very same code changes, as in my original V1 code. So, thank you very much for porting my code to the current dev branch code base, Avinoam.

In my opinion this code (V2) is fine for pushing. If anyone else wants to review this, please have a look now.

Hartmut <hardy>
Thu 08 Nov 2018 10:14:35 PM UTC, comment #5: 

Attached modified version, based on current dev.
Please review.

(file #45389)

Avinoam Kalma <avinoam>
Group Member
Fri 16 Feb 2018 06:41:39 PM UTC, comment #4: 

@Marko: Yes, the V1 m-file is based on a one year old "default" branch of the image package. So it is really missing all improvements from the last 12 months. I hope it helps you anyways.

Hartmut <hardy>
Fri 16 Feb 2018 10:56:02 AM UTC, comment #3: 

Thank you Hardy.

ConvexImage works as a charm.
However, there is a regresion in the orientation calculation. Orientation has been fixed in the image package 2.6.2,
Is it possible regionprops you have attached doesn't contain this fix? I should be able to merge this manually...

Marko <markobe>
Thu 15 Feb 2018 03:54:20 PM UTC, comment #2: 

@Marko: I will attach the file regionprops_V1.m that includes this patch (V1) already. You will need to rename it to regionprops.m and put it where your current regionprops.m sits, i.e. substitute the old function file of the image package.

Please leave a note here on the bug tracker, if those new properties work as expected for you. Thanks.

(file #43329)

Hartmut <hardy>
Thu 15 Feb 2018 02:34:03 PM UTC, comment #1: 

I'm sorry for dumb question. But how do I apply patch?

Marko <markobe>
Mon 30 Jan 2017 11:35:20 PM UTC, original submission:  

Attached is a PATCH (V1) that implements the missing features

  • ConvexHull
  • ConvexImage
  • ConvexArea
  • Solidity

in regionprops.m

This patch also adds

  • help strings for those new features
  • Matlab compatible tests for those new features

The tests are all passing. Only one xtest is failing, because of an imperfect workaround for bug #50188 in ConvexImage. But even those results are of same quality as the Matlab results.

Hartmut <hardy>


(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:

Attached Files
file #45389:  regionprops_V2.m added by avinoam (69KiB - application/octet-stream)
file #43329:  regionprops_V1.m added by hardy (61KiB - text/x-objcsrc)


Depends on the following items: None found

Items that depend on this one: None found


Carbon-Copy List
  • -email is unavailable- added by avinoam (Updated the item)
  • -email is unavailable- added by markobe (Posted a comment)
  • -email is unavailable- added by hardy (Submitted the item)
  • -email is unavailable- added by hardy (adding people to cc who care about the image package)
  • -email is unavailable- added by hardy (adding people to cc who care about the image package)

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.


    Follow 8 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2018-11-11 avinoam StatusIn Progress Done
        Open/ClosedOpen Closed
    2018-11-08 avinoam Attached File- Added regionprops_V2.m, #45389
        StatusNone In Progress
    2018-02-15 hardy Attached File- Added regionprops_V1.m, #43329
    2017-01-30 hardy Attached File- Added regionprops_convex-properties_V1.patch, #39621
        Carbon-Copy- Added avinoam
        Carbon-Copy- Added carandraug

    Back to the top

    Powered by Savane 3.13-ec27.
    Corresponding source code