patchGNU Octave - Patches: patch #9238, __unimplemented__: check if input...

 
 

patch #9238: __unimplemented__: check if input is class method

Submitter:  Colin Macdonald <cbm>
Submitted:  Wed 25 Jan 2017 07:37:11 AM UTC
   
 
Category:  Core : other Priority:  5 - Normal
Status:  Done Privacy:  Public
Assigned to:  siko1056 Open/Closed:  Closed
* Mandatory Fields

Add a New Comment Rich Markup
   

Sat 04 Feb 2017 12:39:21 PM UTC, comment #5: 

Alright, I think bug #49694 is reason enough to let the Octave users take advantage of this very soon.

Pushed: http://hg.savannah.gnu.org/hgweb/octave/rev/d99584de7d72

Kai Torben Ohlhus <siko1056>
Group Member
Sat 04 Feb 2017 05:47:22 AM UTC, comment #4: 

As another example, here's a bug report that would likely have been avoided with this patch: https://savannah.gnu.org/bugs/?func=detailitem&item_id=49694

Colin Macdonald <cbm>
Sat 04 Feb 2017 05:07:30 AM UTC, comment #3: 

I intended it for the development branch.  But I'm fine with it going into 4.2.1 as well.

> did your users need that information, maybe open bug reports


Yes people do ask about this issue on "help-octave@gnu.org".  I was prompted to do this fix by a recently private email reporting that dsolve doesn't work.

Colin Macdonald <cbm>
Sat 04 Feb 2017 12:57:11 AM UTC, comment #2: 

Thank you for your patch. It really might help the user and the formatting is perfect. Do you expect your patch to get into 4.2.1 (did your users need that information, maybe open bug reports?) or is the development branch sufficient?

Kai Torben Ohlhus <siko1056>
Group Member
Wed 25 Jan 2017 07:38:03 AM UTC, comment #1: 

Example showing the new behaviour:


octave:1> dsolve
warning: the 'dsolve' function belongs to the symbolic package from Octave Forge
which you have installed but not loaded.  To load the package, run 'pkg
load symbolic' from the Octave prompt.

Please read <http://www.octave.org/missing.html> to learn how you can
contribute missing functionality.
error: 'dsolve' undefined near line 1 column 1
octave:1> pkg load symbolic
octave:2> dsolve
warning: 'dsolve' is a method of class 'sym'; it must be called with a 'sym'
argument (see 'help @sym/dsolve').

Please read <http://www.octave.org/missing.html> to learn how you can
contribute missing functionality.
error: 'dsolve' undefined near line 1 column 1


Colin Macdonald <cbm>
Wed 25 Jan 2017 07:37:11 AM UTC, original submission:  

check if input is class method before declaring it unimplemented

Octave helpfully checks for functions that are implemented in Octave
Forge packages.  If one of those function names is actually a class
method (of a class provided by the package) and the package is loaded,
then the resulting warning incorrectly states it is unimplemented.
Instead, we give a hint and link to the appropriate help call.
This commit adds this support for the "symbolic" package but the
support is general if other packages need it too.

  • scripts/help/__unimplemented__.m: improve behaviour for class methods
Colin Macdonald <cbm>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by siko1056 (Posted a comment)
  • -email is unavailable- added by cbm (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 5 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2017-02-04 siko1056 Open/ClosedOpen Closed
    2017-02-04 siko1056 StatusNeed Info Done
    2017-02-04 siko1056 StatusNone Need Info
        Assigned toNone siko1056
    2017-01-25 cbm Attached File- Added check_if_input_is_class_method_before_declaring_it_unimplemented.patch, #39553

    Back to the top

    Powered by Savane 3.13-d3ae.
    Corresponding source code