patchGNU Octave - Patches: patch #9175, ode15i and ode15s

 
 

patch #9175: ode15i and ode15s

Submitted by:  Carlo de Falco <cdf>
Submitted on:  Tue 29 Nov 2016 02:17:21 PM UTC  
 
Category:  Core : new function Priority:  5 - Normal
Status:  Done Privacy:  Public
Assigned to:  Carlo de Falco <cdf> Open/Closed:  Closed

Add a New Comment (Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Fri 16 Dec 2016 10:34:25 AM UTC, comment #2: 

pushed with these changesets:

changeset:   22945:31bd8a50d44c
user:        Francesco Faccio <francesco.faccio@mail.polimi.it>
date:        Tue Aug 23 02:13:28 2016 +0200
summary:     Add Sundials library support

changeset:   22946:ee1c77705fcd
user:        Francesco Faccio <francesco.faccio@mail.polimi.it>
date:        Tue Aug 23 02:31:51 2016 +0200
summary:     Refactor code for ode solvers and private functions

changeset:   22947:4c56f3ffec04
user:        Francesco Faccio <francesco.faccio@mail.polimi.it>
date:        Tue Aug 23 03:19:11 2016 +0200
summary:     Add functions ode15i and ode15s

changeset:   22948:284bbb0328f2
user:        Carlo de Falco <carlo.defalco@polimi.it>
date:        Tue Nov 01 06:41:29 2016 +0100
summary:     Update odei5{i,s} code for Octave 4.3.0+ and Sundials 2.7.0.

changeset:   22949:51c9eded34ee
user:        Carlo de Falco <carlo.defalco@polimi.it>
date:        Wed Nov 02 06:28:24 2016 +0100
summary:     Fix access method to sundials 2.7.0 sparse matrix structure.

changeset:   22950:a1f1ab76aa64
bookmark:    @
tag:         tip
user:        Carlo de Falco <carlo.defalco@polimi.it>
date:        Thu Dec 15 15:10:28 2016 +0100
summary:     Fix changes lost when closing ode15i branch.

Carlo de Falco <cdf>
Project MemberIn charge of this item.
Thu 01 Dec 2016 10:22:26 PM UTC, comment #1: 

Hi Carlo,

I see you want to push both ode15{i,s} and the configure tests for Sundials through a single patch, so please add the following description to the ChangeLog:

*build-aux/subst-config-vals.in.sh: Add configuration variables for sundials_ida, sundials_nvecserial and klu libraries.
*build-aux/subst-cross-config-vals.in.sh: Add configuration variables for sundials_ida, sundials_nvecserial and klu libraries.
*configure.ac: Check for sundials_ida, sundials_nvecserial and klu headers and functions. Check whether sundials_ida has been configured with double precision. Set configuration variables and flags.
*libinterp/build-env.h: Add variables to build_env namespace.
*libinterp/build-env.in.cc: Add variables to build_env namespace.
*m4/acinclude.m4: Add macro to test whether sundials_ida has been configured with double precision.
*scripts/ode/decic.m: Add function decic.m for consistent initial value computation.
*scripts/ode/module.mk: Add functions to function list.
*src/mkoctfile.in.cc: Get variables in order to generate oct-file.

As a title, you can write "Add functions ode15i, ode15s and Sundials library support".

Francesco

Francesco Faccio <francesco_faccio>
Tue 29 Nov 2016 02:17:21 PM UTC, original submission:  

Hi,

The attached patch implements the inclusion
of ode15s and ode15i DAE solvers into Octave core.

This is the result of Francesco Faccio's GSOC 2016 project
that I have been keeping up to date in a separate bitbucket
repository until now.

The repository is here:
https://bitbucket.org/cdf1/octave/branch/ode15i

The patch is obtained by

hg diff -r ode15i:default

There patch is of course not perfect but I'd rather
have it included soon and continue development in the
main repository before substantial changes are made
to core that make it to hard to keep up to date.

@Francesco could you help me write a comprehensive
ChangeLog message to describe the whole code?

You did this already at the end of the of the project:

Add functions ode15i and ode15s

*libinterp/dldfcn/__ode15__.cc: Add oct-file for m-files ode15i and ode15s.
*scripts/ode/ode15i.m: Add function ode15i.m.
*scripts/ode/ode15s.m: Add function ode15s.m.
*scripts/ode/private/check_default_input.m: Add private function to check default input of ode15i and ode15s.
*libinterp/dldfcn/module-files: Add __ode15__.cc and its flags.

Does this need to be updated?

Carlo de Falco <cdf>
Project MemberIn charge of this item.

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #39097:  open_Dt6OKAWH.txt added by cdf (109KiB - text/plain)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by francesco_faccio (Posted a comment)
  • -email is unavailable- added by cdf (Submitted the item)
  • -email is unavailable- added by cdf
  • -email is unavailable- added by cdf
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

     

     

    Follow 6 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2016-12-16 cdf StatusReady For Test => Done
        Open/ClosedOpen => Closed
    2016-11-29 cdf Carbon-Copy- => Added corno@gsc.tu-darmstadt.de
        Carbon-Copy- => Added francesco.faccio@mail.polimi.it
        Carbon-Copy- => Added schoeps@temf.tu-darmstadt.de
    2016-11-29 cdf Attached File- => Added open_Dt6OKAWH.txt, #39097

    Back to the top


    Powered by Savane 3.5