patchGNU Octave - Patches: patch #9047, Array constructor from std...

 
 

patch #9047: Array constructor from std sequence containers

Submitter:  Carnë Draug <carandraug>
Submitted:  Mon 11 Jul 2016 02:17:53 PM UTC
   
 
Category:  Core : new feature Priority:  5 - Normal
Status:  Done Privacy:  Public
Assigned to:  carandraug Open/Closed:  Closed
* Mandatory Fields

Add a New Comment Rich Markup
   

Mon 18 Jul 2016 04:11:54 PM UTC, comment #2: 
Carnë Draug <carandraug>
Group Member
Fri 15 Jul 2016 02:49:12 PM UTC, comment #1: 

My main problems with this patch are:

  1. it is coded in the header (alternatively, we could declare a set of containers but I think this is better so it can support any class that looks like a std sequence container)
  2. repeats a very small snippet from Array
  3. the for loop takes a reference to the values which is kinda pointless in a vector of ints but may mean less copying for complex objects
Carnë Draug <carandraug>
Group Member
Mon 11 Jul 2016 02:17:53 PM UTC, original submission:  

I wrote a simple Array constructor that takes any class with same interface as the sequence containers in std. It has the same interface as the reshape constructor.

Carnë Draug <carandraug>
Group Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #37802:  array-std-constructor.cset added by carandraug (4KiB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by siko1056 (Updated the item)
  • -email is unavailable- added by carandraug (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 5 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2016-07-18 carandraug StatusIn Progress Done
        Open/ClosedOpen Closed
    2016-07-12 siko1056 StatusNone In Progress
        Assigned toNone carandraug
    2016-07-11 carandraug Attached File- Added array-std-constructor.cset, #37802

    Back to the top

    Powered by Savane 3.13-bb6a.
    Corresponding source code