patchGNU Octave - Patches: patch #8897, Fix regression for coordinate...

 
 

patch #8897: Fix regression for coordinate transforms on 3D arrays

Submitter:  Colin Macdonald <cbm>
Submitted:  Mon 01 Feb 2016 05:08:04 AM UTC
   
 
Category:  None Priority:  5 - Normal
Status:  Done Privacy:  Public
Assigned to:  None Open/Closed:  Closed
* Mandatory Fields

Add a New Comment Rich Markup
   

Tue 02 Feb 2016 05:55:09 PM UTC, comment #1: 

I checked in your patch on the stable branch here (http://hg.savannah.gnu.org/hgweb/octave/rev/5f62b5dae8b1).

I did a few extra things as well.  We like to include the bug number in the commit message so you can rapidly search Mercurial to find which patches were related to a bug.  I did that.  The commit message also has the form of

one-line summary

general description

per-file change notes

You had the first two items, but I added the per-file change notes.

Who knew such simple functions could hide such complexity?  I found, for example, that in the 1-input case we weren't checking whether the variable was even numeric.  I added a check for that as well as BIST tests to verify that the code was correct.

I also changed the error messages to reference by name the input variables that were incorrect.  For example, 'X, Y, Z must be numeric...'.  We have been trying to change all such instances in the Octave code base, but there is a lot of code and it is a work in progress.

Marking as done.

Rik <rik5>
Group administrator
Mon 01 Feb 2016 05:08:04 AM UTC, original submission:  

I propose for both tip and 4.0.1, but of course up to you.

Colin Macdonald <cbm>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by rik5 (Posted a comment)
  • -email is unavailable- added by cbm (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 3 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2016-02-02 rik5 StatusNone Done
        Open/ClosedOpen Closed
    2016-02-01 cbm Attached File- Added fix_regression_for_coordinate_transforms_on_3D_arrays.patch, #36225

    Back to the top

    Powered by Savane 3.13-02a9.
    Corresponding source code