patchGNU Octave - Patches: patch #8831, Moved ode23.m from OdePkg to core

 
 

patch #8831: Moved ode23.m from OdePkg to core

Submitted by:  Stefan Miereis <stefanm>
Submitted on:  Sat 12 Dec 2015 05:41:56 PM UTC  
 
Category:  None Priority:  5 - Normal
Status:  Done Privacy:  Public
Assigned to:  Carlo de Falco <cdf> Open/Closed:  Closed

Add a New Comment (Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

( Jump to the original submission)

Thu 24 Dec 2015 12:36:41 AM UTC, comment #8: 

Question about the patch for odepkg: Is there a reason for ode45 still being in the manual or can I remove mentions of it together with references to ode23 and runge_kutta_23?

Stefan Miereis <stefanm>
Tue 15 Dec 2015 06:06:12 PM UTC, comment #7: 

pushed your patch and a few fixes.
closing this ticket.
c.

Carlo de Falco <cdf>
Project MemberIn charge of this item.
Tue 15 Dec 2015 05:35:42 PM UTC, comment #6: 

stefan, did you ever run

make check

or at least

test od23

to see whether your patch works?

Carlo de Falco <cdf>
Project MemberIn charge of this item.
Tue 15 Dec 2015 12:59:25 PM UTC, comment #5: 

I added a new patch with the latest version of ode23.m. Since the new ode23 needs runge_kutta_23, I included it in this patch.

Carlo, could you take a look at the copyright notices, to see if they're okay?

(file #35749)

Stefan Miereis <stefanm>
Mon 14 Dec 2015 06:41:46 AM UTC, comment #4: 

Thanks!

As for the patch on odepkg, it should also take care of the INDEX file and of the manual.

c.

Carlo de Falco <cdf>
Project MemberIn charge of this item.
Mon 14 Dec 2015 02:10:10 AM UTC, comment #3: 

Sorry, my bad. I used the ode23.m from odepkg-0.8.5, I will rewrite the patch for the latest version.

Stefan Miereis <stefanm>
Sun 13 Dec 2015 10:08:05 PM UTC, comment #2: 

Stefan, thanks for the patch.

But where does this implementation of ode23 come from?
This is not the version that was in the current odepkg repository ...

Is this taken from an old odepkg release?

In the new odepkg (and in the ode solvers in core)
ode23 uses integrate_adaptive and runge_kutta_23 to
implement the algorithm.

c.

Carlo de Falco <cdf>
Project MemberIn charge of this item.
Sat 12 Dec 2015 06:36:57 PM UTC, comment #1: 

I created a patch that removes ode23 from the odepkg package, as requested by cdf.

(file #35713)

Stefan Miereis <stefanm>
Sat 12 Dec 2015 05:41:56 PM UTC, original submission:  
  • Added ode23.m to scripts/ode
  • Added reference to ode23.m to /scripts/modules.mk
  • Added @DOCSTRING to doc/interpreter/diffeq.txi
  • Edited @seealso in ode45.m
Stefan Miereis <stefanm>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #35749:  codesprint_2015_ode23_runge_kutta_23.diff added by stefanm (34KiB - application/x-download)
file #35713:  codesprint2015_ode23_forge.diff added by stefanm (26KiB - application/x-download)
file #35710:  codesprint2015_ode23.diff added by stefanm (35KiB - application/x-download)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by cdf (Posted a comment)
  • -email is unavailable- added by stefanm (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

     

     

    Follow 8 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2015-12-15 cdf StatusIn Progress => Done
        Open/ClosedOpen => Closed
    2015-12-15 stefanm Attached File- => Added codesprint_2015_ode23_runge_kutta_23.diff, #35749
    2015-12-14 cdf StatusNeed Info => In Progress
    2015-12-13 cdf StatusNone => Need Info
        Assigned toNone => cdf
    2015-12-12 stefanm Attached File- => Added codesprint2015_ode23_forge.diff, #35713
    2015-12-12 stefanm Attached File- => Added codesprint2015_ode23.diff, #35710

    Back to the top


    Powered by Savane 3.5