patchGNU Octave - Patches: patch #8684, GUI - Find/replace - keep focus on...

 
 

patch #8684: GUI - Find/replace - keep focus on Find What and select all text when dialog opens

Submitted by:  Rafael Monteiro <rafaelmonteiro>
Submitted on:  Mon 15 Jun 2015 01:34:09 PM UTC  
 
Category:  None Priority:  5 - Normal
Status:  Done Privacy:  Public
Assigned to:  None Open/Closed:  Closed

Add a New Comment (Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sat 15 Aug 2015 07:04:39 AM UTC, comment #4: 
Torsten Lilge <ttl>
Project Member
Fri 14 Aug 2015 08:24:42 PM UTC, comment #3: 

OK took a bit of time but I just tested your (Torsten's) modified patch.

Seems to work fine.

Torsten, will you push or shall I do that?

Philip Nienhuis <philipnienhuis>
Project Member
Sat 04 Jul 2015 08:15:13 AM UTC, comment #2: 

For me, the patch does not implement the desired behavior. Looking at the code, the added lines are at the end of the constructor which is not called when the find dialog already exists and is reopened.

Please find attached an updated patch where the two lines are added to the function init_search_text, which is called from the editor-tab each time the find dialog is opened (whether already existing or not).

(file #34376)

Torsten Lilge <ttl>
Project Member
Wed 17 Jun 2015 08:18:20 PM UTC, comment #1: 

Tried your patch, works fine.

IMO the "old" behavior is actually a (minor) bug, so I'll ask a core dev what to do with it.

@Torsten, can this go to stable or should it be on dev branch?

Philip Nienhuis <philipnienhuis>
Project Member
Mon 15 Jun 2015 01:34:09 PM UTC, original submission:  

If one opens the find/replace dialog, perform a search, then close and reopen the dialog, the focus should be on the "Find what" field with the text selected (this is Matlab's behavior).

The attached patch does that.

Rafael Monteiro <rafaelmonteiro>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #34376:  gui_find_focus_v2.diff added by ttl (842B - text/x-diff)
file #34225:  gui_find_focus.diff added by rafaelmonteiro (772B - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by ttl (Updated the item)
  • -email is unavailable- added by philipnienhuis
  • -email is unavailable- added by rafaelmonteiro (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

     

     

    Follow 5 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2015-08-15 ttl Open/ClosedOpen => Closed
    2015-08-15 ttl StatusNone => Done
    2015-07-04 ttl Attached File- => Added gui_find_focus_v2.diff, #34376
    2015-06-17 philipnienhuis Carbon-Copy- => Added ttl
    2015-06-15 rafaelmonteiro Attached File- => Added gui_find_focus.diff, #34225

    Back to the top


    Powered by Savane 3.6