patchGNU Octave - Patches: patch #8614, New gui icons

 
 

patch #8614: New gui icons

Submitter:  Torsten Lilge <ttl>
Submitted:  Sat 28 Feb 2015 04:43:11 PM UTC
   
 
Category:  None Priority:  5 - Normal
Status:  Done Privacy:  Public
Assigned to:  None Open/Closed:  Closed
* Mandatory Fields

Add a New Comment Rich Markup
   

Jump to the original submission

Wed 04 Mar 2015 08:15:57 PM UTC, comment #14: 

@Dan, comment #4:

"Show Octave directory" and "Set Octave directory" are setting the browser dir to the Octave dir or the octave dir to the currently shown dir in the browser resp.. They are disabled when the preference to synchronize both directories is active (settings dialog).





Torsten Lilge <ttl>
Group Member
Wed 04 Mar 2015 07:44:07 PM UTC, comment #13: 

I have pushed the patch, for now with already converted png icons accompanying the svg sources. Obsolete icons were removed.

Torsten Lilge <ttl>
Group Member
Wed 04 Mar 2015 01:31:52 PM UTC, comment #12: 

If using png icons is much simpler, then I'd say generate and use those instead.

Also, can we eliminate all the obsolete icons in the source tree?  Is it easy to find all icons which are actually used now and compare against the icons in the source tree?

John W. Eaton <jwe>
Group administrator
Wed 04 Mar 2015 09:15:58 AM UTC, comment #11: 

Thanks.  I'm not completely following what the StackOverflow discussion is saying.  I'm just not Windows oriented.  iconengine and imageformats are DLL's the Octave creates stored in a plugins directory of the local Octave build tree?

Anyway, let me toss out something that might go somewhere.  Is there some way to write a short C++ program, say "find_qt_dll_dir.cc", that can create some object like the qt.conf or QLibraryInfo class and then dump out the place that these DLL's should go or already reside?

That C++ program could be compiled first (it shouldn't require any functions or libraries beyond what Octave needs, so no problems), then as part of the install use the return result of ./find_qt_dll_dir executable to copy the DLLs.



Dan Sebald <sebald>
Wed 04 Mar 2015 06:06:08 AM UTC, comment #10: 

The problem is not the location of the icons themselves but of the dlls that are required in order to use svg icons in windows. These are the directories "iconengines" and "imageformats" which are now located in "plugins" within the application folder. From http://qt-project.org/doc/qt-4.8/qt-conf.html, this is the default location. However, on http://stackoverflow.com/questions/4318990/svg-icons-not-showing-up-in-qt-release-build-in-windows, there are some other locations mentioned for making svg icons work on windows. I was also playing around with a qt.conf file, but without success.

That's why I am wondering whether it would be better to create png icons during the build process providing definitely usable icons on all window systems.


Torsten Lilge <ttl>
Group Member
Tue 03 Mar 2015 10:26:56 PM UTC, comment #9: 

What is the link for the Qt documentation regarding Windows icon directory?

Dan Sebald <sebald>
Tue 03 Mar 2015 10:14:27 PM UTC, comment #8: 

I'm not sure about the PNG image process, but as far as placing the icons on the Windows file system, if there are multiple directories they could possibly reside then making copies in all those locations might not be so bad if the icons use relatively little hard drive space.  Alternatively, for Windows perhaps the icon files could be accessed with a descriptive path rather than having the Qt tools look for them?

Dan Sebald <sebald>
Tue 03 Mar 2015 08:45:20 PM UTC, comment #7: 

I am not sure if the issue can really be easily fixed in windows since several locations for the relevant directories are mentioned in the internet and the one which is currently used by the mxe-build is the one that is mentioned in the Qt documentation.

Maybe it would be easier and safer to create png files during the build process? What changes would be required for this?



Torsten Lilge <ttl>
Group Member
Tue 03 Mar 2015 04:28:03 PM UTC, comment #6: 

Just some issue with Windows that's mentioned in the original post.  I'd say though commit this one to avoid merge conflicts that will arise after not too long, and then create a bug report for the Windows issues.

Dan Sebald <sebald>
Tue 03 Mar 2015 02:55:48 PM UTC, comment #5: 

Other than appearance issues (not they they aren't important, but we could argue endlessly about that) and the build issues on Windows, which I assume could be handled in the mxe-octave build system for now, is there any reason not to go ahead and commit this patch?

John W. Eaton <jwe>
Group administrator
Sun 01 Mar 2015 05:26:28 PM UTC, comment #4: 

One issue with the "play" icon is that it is used twice in the toolbar, for both "save and run" and "continue".  After applying your latest patch and replacing


  _run_action = add_action (_run_menu,  resource_manager::icon ("media-playback-start"),
          tr ("Save File and Run"), SLOT (request_run_file (bool)));


with


  _run_action = add_action (_run_menu,  resource_manager::icon ("system-run"),
          tr ("Save File and Run"), SLOT (request_run_file (bool)));


results in the gears icon for the default theme icons.  That would be my preference (actually, the file with gears icon would make more sense because it is both save and run--but of course that is clarified as part of the tool tip).

The fallback icons are fine with me.  Just noting that, yes, the default icons are more immediately understandable to me.  There's a moment of hesitation when seeing the fallback icon set.  Just a matter of what one is used to using--but naturally it only takes a couple minutes to become familiar.

I see that there is a big-gear icon associated with "Browse your files", I assume because that drop-down menu has a lot of different capabilities.  Is there another more appropriate icon?  I can't think of one.  A lot of the actions there are associated with "path".  What are "Show Octave directory" and "Set Octave directory" intended to do?  They are greyed even if I select one of the directories in the file system list.

Also, note that next to the big-gear icon is an up arrow with tooltip "Move up one directory".  At the top-middle of the main window is a similar action up arrow.  The tool tip for that one reads "One directory up".  Consider making those the same phrase because they are the same action.

Dan Sebald <sebald>
Sun 01 Mar 2015 11:26:33 AM UTC, comment #3: 

Dan, thank you for testing. Attached an updated patch (it replaces the old one) with an exchanged order of prev/next breakpoints and slightly revised step-in/step-out icons. I have taken a look at the Code::Blocks icons and they are quite similar.
I think the "play" icon is the one that most users would expect.

The second patch (force_tango_icons.patch) has to be applied on top and forces the use of the tango icons on all platforms for testing.

The possibility of passing parameters to a function when using "run" or a confirmation for removing all breakpoints should be discussed in separate feature requests.

(file #33216, file #33217)

Torsten Lilge <ttl>
Group Member
Sun 01 Mar 2015 10:01:03 AM UTC, comment #2: 

Regard prev/next order, I've seen at least one editor that has find-next on the left and find-previous on the right, so I guess it is somewhat arbitrary which is used.

Also, you've used the media play button for "save and run".  I've seen an editor that uses an icon for a similar action that is a little file with a gear, or a set of multiple gears.  I'm not sure what name that is though.  On the internet I see a name "system-run" associated with icon files like "document-save".  Perhaps "system-run" is the gears icon.

Dan Sebald <sebald>
Sat 28 Feb 2015 06:11:34 PM UTC, comment #1: 

Looks nice.  I like the smaller icons (but I just notice the existing setup allows adjusting icons already).

Could you include a snapshot of the icons when the default theme is missing?  E.g. Windows.  Or is there a way to make that happen easily even though the defaults are present?

Should the prev/next breakpoint positions be switched (i.e., prev on the left)?  A lot of one-line text search functions have the previous button on the left.  (E.g., a browser cntrl-f "Find:".)

The "step-in" and "step-out" icons aren't so immediately understandable.  The direction of the arrows seems like it should go the other direction for my intuition.  It's a hard thing to represent, even though in a programmers it is sort of very clear what the "step in" and "step out" phrases imply.  I wonder if slightly changing the graphic might help, in particular the position of the arrow.  I'll try to illustrate what I mean, but there probably isn't enough space for this on the icon.  Say = represents the lines/blocks in the icons just as they currently are, and -> is the swooshing arrow.  Below are two "icons", for which I will not mention which is which.  Tell me what your first impression is about which is which:


=
   =
 <-
=



=
 ->
   =
=


[To me the first sudo-icon looks like stepping out and the second sudo-icon looks like stepping in.]

Beyond the look and feel.  I wonder if there should be an option to confirm clearing the breakpoints.  Also, in the "Run" menu it would be nice to have some way of entering a string of text that would serve as the argument of the function being run (if it is a function).  Or maybe it would be an edit-box right next to the "run" icon.  For example, one might put non-editable "(" and ")" characters and between that the user enters something like


"(" pi               ")"
"(" 15,xval,yval     ")"
"(" sqrt(3)          ")"


where any variables entered (xval and yval) would have to be global in order for the "run" to work correctly.

Dan Sebald <sebald>
Sat 28 Feb 2015 04:43:11 PM UTC, original submission:  

This patch provides new icons for the gui as a basis for discussion. If available, the icons are taken from the actual system theme giving the usual look and feel. If not - e.g. on windows and mac systems -, the related icons from the tango icon set are taken (in svg-format). In addition, new icons for breakpoints and debugging created with elements of the tango icons are included.

There is some oddity in windows though: For making the svg-icons work in windows the folder "plugins" in the installation directory has to be copied into the folder "bin". Moreover octave has to be started with "octave.bat" or "bin/octave-gui.exe".




Torsten Lilge <ttl>
Group Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #33216:  icons_20150301_01.patch added by ttl (851KiB - text/x-diff)
file #33217:  force_tango_icons.patch added by ttl (758B - text/x-diff)
file #33210:  icons_20150228_01.patch added by ttl (824KiB - text/x-diff)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by jwe (Posted a comment)
  • -email is unavailable- added by sebald (Posted a comment)
  • -email is unavailable- added by ttl (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 5 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2015-03-04 ttl StatusNone Done
        Open/ClosedOpen Closed
    2015-03-01 ttl Attached File- Added icons_20150301_01.patch, #33216
        Attached File- Added force_tango_icons.patch, #33217
    2015-02-28 ttl Attached File- Added icons_20150228_01.patch, #33210

    Back to the top

    Powered by Savane 3.13-f8d8.
    Corresponding source code