patchGNU Octave - Patches: patch #8576, instrument-control: win32 serial

 
 

patch #8576: instrument-control: win32 serial

Submitted by:  John Donoghue <lostbard>
Submitted on:  Wed 19 Nov 2014 04:03:14 PM UTC  
 
Category:  None Priority:  5 - Normal
Status:  Done Privacy:  Public
Assigned to:  John Donoghue <lostbard> Open/Closed:  Closed

Add a New Comment (Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

( Jump to the original submission)

Mon 24 Nov 2014 08:42:38 PM UTC, comment #6: 

Thanks!!!

Marking patch as closed

John Donoghue <lostbard>
Project MemberIn charge of this item.
Fri 21 Nov 2014 04:02:11 PM UTC, comment #5: 

You are too fast :)  Well, I pushed your patch to sourceforge and github. Both are in sync now (except the modbus stuff). I'll rebase my latest changes later.

Stefan Mahr <dac922>
Fri 21 Nov 2014 01:01:19 PM UTC, comment #4: 

How about this then? - win and lin files are separated, with configure.ac/Makefile.am comping in the correct ones.

(file #32512)

John Donoghue <lostbard>
Project MemberIn charge of this item.
Fri 21 Nov 2014 10:43:13 AM UTC, comment #3: 

Uh, you're right. I must have been dreaming. :) I'll push a concept this weekend.

Stefan Mahr <dac922>
Thu 20 Nov 2014 01:02:46 PM UTC, comment #2: 

I had thought about separating the win32 parts but then didn't.

I couldn't see anything in the repo that was separating the OS specific parts - it is a plan to do, or something started that hasn't been commited yet?

John Donoghue <lostbard>
Project MemberIn charge of this item.
Wed 19 Nov 2014 10:59:53 PM UTC, comment #1: 

Thanks for your patch. I already made some changes to serial part of instrument control to make it easier to maintain for different OS. I did not have enough time to polish and push to hg/sourceforge. My git repository with latest changes is here: https://github.com/dac922/octave-instrument-control

However, the plan is to put all OS dependent parts to different files. For example:

serial_class.*
-> serial_class_lin.*
-> serial_class_win32.*

Would be great if you would take a look to latest source and give some comments. Adapting your patch should be easy.

Stefan Mahr <dac922>
Wed 19 Nov 2014 04:03:14 PM UTC, original submission:  

Heres a patch to instrument control for win32 serial port usage.

John Donoghue <lostbard>
Project MemberIn charge of this item.

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #32512:  0001-Add-win32-serial-implementation.patch added by lostbard (56KiB - application/octet-stream)
file #32477:  serial_win32.patch added by lostbard (21KiB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by dac922 (Posted a comment)
  • -email is unavailable- added by lostbard (Submitted the item)
  • -email is unavailable- added by lostbard
  • -email is unavailable- added by lostbard
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

     

     

    Follow 7 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2014-11-24 lostbard StatusNone => Done
        Assigned toNone => lostbard
        Open/ClosedOpen => Closed
    2014-11-21 lostbard Attached File- => Added 0001-Add-win32-serial-implementation.patch, #32512
    2014-11-19 lostbard Attached File- => Added serial_win32.patch, #32477
        Carbon-Copy- => Added dac922
        Carbon-Copy- => Added

    Back to the top


    Powered by Savane 3.5