patchGNU Octave - Patches: patch #8568, Remove unnecessary build warnings...

 
 

patch #8568: Remove unnecessary build warnings in __ichol__.cc.

Submitted by:  Kai Torben Ohlhus <siko1056>
Submitted on:  Mon 10 Nov 2014 04:08:47 PM UTC  
 
Category:  None Priority:  5 - Normal
Status:  Done Privacy:  Public
Assigned to:  None Open/Closed:  Closed

Add a New Comment (Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Tue 11 Nov 2014 06:32:36 AM UTC, comment #3: 

The info in the Mercurial changeset says which branch your changeset applies to.  If no branch is explicitly shown, default is assumed.

John W. Eaton <jwe>
Project Administrator
Tue 11 Nov 2014 06:19:06 AM UTC, comment #2: 

Yes, thank you very much Rik. I forgot to mention, that I'm on the default branch.

Kai Torben Ohlhus <siko1056>
Project Member
Mon 10 Nov 2014 10:19:40 PM UTC, comment #1: 

I changed the commit message to follow Octave guidelines to reference the function involved in the file. 

__ichol__.cc: Removed unused variables causing compilation warnings.

* __ichol__.cc (ichol_0): Remove Llist_len variable.
* __ichol__.cc (ichol_t): Remove Llist_len, jw variables.

I checked in your changeset on the default branch and am closing the report.

Rik <rik5>
Project Administrator
Mon 10 Nov 2014 04:08:47 PM UTC, original submission:  

The attached patch addresses the following warnings:

  libinterp/dldfcn/__ichol__.cc: In instantiation of 'void ichol_0(octave_matrix_t&, std::string) [with octave_matrix_t = SparseMatrix; T = double; T (*     ichol_mult)(T, T) = ichol_mult_real; bool (* ichol_checkpivot)(T) = ichol_checkpivot_real; std::string = std::basic_string<char>]':
  libinterp/dldfcn/__ichol__.cc:221:50:   required from here
  libinterp/dldfcn/__ichol__.cc:82:63: warning: unused variable 'Llist_len' [-Wunused-variable]
      octave_idx_type j1, jend, j2, jrow, jjrow, j, jw, i, k, jj, Llist_len, r;   
                                                                  ^               
  libinterp/dldfcn/__ichol__.cc: In instantiation of 'void ichol_0(octave_matrix_t&, std::string) [with octave_matrix_t = SparseComplexMatrix; T = std::    complex<double>; T (* ichol_mult)(T, T) = ichol_mult_complex; bool (* ichol_checkpivot)(T) = ichol_checkpivot_complex; std::string = std::basic_string<char>]':
  libinterp/dldfcn/__ichol__.cc:231:53:   required from here
  libinterp/dldfcn/__ichol__.cc:82:63: warning: unused variable 'Llist_len' [-Wunused-variable]
  libinterp/dldfcn/__ichol__.cc: In instantiation of 'void ichol_t(const octave_matrix_t&, octave_matrix_t&, const T*, T, std::string) [with octave_matr    ix_t = SparseMatrix; T = double; T (* ichol_mult)(T, T) = ichol_mult_real; bool (* ichol_checkpivot)(T) = ichol_checkpivot_real; std::string = std::basic_string<char>]':
  libinterp/dldfcn/__ichol__.cc:485:67:   required from here
  libinterp/dldfcn/__ichol__.cc:247:41: warning: unused variable 'jw' [-Wunused-variable]
     octave_idx_type j, jrow, jend, jjrow, jw, i, k, jj, Llist_len, total_len,   
                                           ^                                     
  libinterp/dldfcn/__ichol__.cc:247:55: warning: unused variable 'Llist_len' [-Wunused-variable]
     octave_idx_type j, jrow, jend, jjrow, jw, i, k, jj, Llist_len, total_len,   
                                                         ^                       
  libinterp/dldfcn/__ichol__.cc: In instantiation of 'void ichol_t(const octave_matrix_t&, octave_matrix_t&, const T*, T, std::string) [with octave_matr    ix_t = SparseComplexMatrix; T = std::complex<double>; T (* ichol_mult)(T, T) = ichol_mult_complex; bool (* ichol_checkpivot)(T) = ichol_checkpivot_complex; std::string = std::basic_    string<char>]':
  libinterp/dldfcn/__ichol__.cc:504:42:   required from here
  libinterp/dldfcn/__ichol__.cc:247:41: warning: unused variable 'jw' [-Wunused-variable]
     octave_idx_type j, jrow, jend, jjrow, jw, i, k, jj, Llist_len, total_len,   
                                           ^                                     
  libinterp/dldfcn/__ichol__.cc:247:55: warning: unused variable 'Llist_len' [-Wunused-variable]
     octave_idx_type j, jrow, jend, jjrow, jw, i, k, jj, Llist_len, total_len,   
                                                         ^   

Kai Torben Ohlhus <siko1056>
Project Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #32399:  __ichol__.cc.diff added by siko1056 (996B - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by jwe (Posted a comment)
  • -email is unavailable- added by rik5 (Posted a comment)
  • -email is unavailable- added by siko1056 (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

     

     

    Follow 3 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2014-11-10 rik5 StatusNone => Done
        Open/ClosedOpen => Closed
    2014-11-10 siko1056 Attached File- => Added __ichol__.cc.diff, #32399

    Back to the top


    Powered by Savane 3.5