patchGNU Octave - Patches: patch #8533, [MXE] Turn off system beeper

 
 

patch #8533: [MXE] Turn off system beeper

Submitted by:  Philip Nienhuis <philipnienhuis>
Submitted on:  Sat 13 Sep 2014 08:58:33 AM UTC  
 
Category:  None Priority:  5 - Normal
Status:  Done Privacy:  Public
Assigned to:  John Donoghue <lostbard> Open/Closed:  Closed

Add a New Comment (Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

( Jump to the original submission)

Fri 03 Oct 2014 12:33:56 AM UTC, comment #8: 

Pushed http://hg.octave.org/mxe-octave/rev/70480095b6ed, which includes setting term to cygwin.

John Donoghue <lostbard>
Project MemberIn charge of this item.
Thu 25 Sep 2014 12:28:52 AM UTC, comment #7: 

I guess easiest is to set the TERM=cygwin pior to running octave in the batch file to ensure it is consistent

John Donoghue <lostbard>
Project MemberIn charge of this item.
Wed 24 Sep 2014 09:08:15 PM UTC, comment #6: 

Out of interest when running octave:

gui:

>> getenv('TERM')

ans = cygwin

>>


cli:
octave:1> getenv('TERM')
ans =
octave:2>

John Donoghue <lostbard>
Project MemberIn charge of this item.
Wed 24 Sep 2014 08:04:21 PM UTC, comment #5: 

Re-opening this patch.

Pushed solution only works for GUI but not for CLI.

What $term is there in the CLI? I tried a 32-bit MSYS window;

Philip@LX230 ~
$ echo $term


Philip@LX230 ~
$ echo $TERM
cygwin

Philip@LX230 ~
$

Philip Nienhuis <philipnienhuis>
Project Member
Tue 16 Sep 2014 06:18:55 PM UTC, comment #4: 

Saw those, thanks.

Closing report

Philip Nienhuis <philipnienhuis>
Project Member
Mon 15 Sep 2014 11:45:00 PM UTC, comment #3: 

ok - pushed to gui-release and added as a ptch in mxe-octave.

John Donoghue <lostbard>
Project MemberIn charge of this item.
Sat 13 Sep 2014 06:01:25 PM UTC, comment #2: 

Never noted your comment on bug #42268. Sorry

I'd say: go ahead and push it.
I made a patch for mxe as that is only used for Windows; if checking for a cygwin terminal is sufficiently reliable your patch is the better one.

Philip Nienhuis <philipnienhuis>
Project Member
Sat 13 Sep 2014 11:23:02 AM UTC, comment #1: 

There was also a bug related to this, in which I had posted a similar patch.
https://savannah.gnu.org/bugs/?42268

in mine, it checked the terminal name before disabling.

John Donoghue <lostbard>
Project MemberIn charge of this item.
Sat 13 Sep 2014 08:58:33 AM UTC, original submission:  

Here's a patch for mxe-octave to turn off the system beep.

The latter is triggered upon every erroneous keyboard press (e.g., when inadvertedly trying to backspace to before the start of an input line) which can be extremely annoying in office environments.

I've patched inputrc in share/octave/m/<version>/startup/ rather than in share/octave/<version>/site/; on Windows that location doesn't matter much.

The patch is attributed to Jason Nicholson who came up with it here:
http://octave.1599824.n4.nabble.com/Octave-Msys-Beep-Disable-on-WIndows-td4656885.html

Philip Nienhuis <philipnienhuis>
Project Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #32085:  silence_beep.cs added by philipnienhuis (793B - text/x-csharp)

 

Digest:
   bug dependencies.

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by lostbard (Posted a comment)
  • -email is unavailable- added by philipnienhuis (Submitted the item)
  • -email is unavailable- added by philipnienhuis
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

     

     

    Follow 11 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2014-10-28 lostbard StatusReady For Test => Done
        Open/ClosedOpen => Closed
    2014-10-03 lostbard Assigned toNone => lostbard
    2014-10-03 lostbard StatusIn Progress => Ready For Test
    2014-09-24 philipnienhuis StatusDone => In Progress
        Open/ClosedClosed => Open
    2014-09-16 philipnienhuis StatusReady For Test => Done
        Open/ClosedOpen => Closed
    2014-09-13 lostbard Dependencies- => Depends on bugs #42268
    2014-09-13 philipnienhuis Attached File- => Added silence_beep.cs, #32085
        Carbon-Copy- => Added lostbard

    Back to the top


    Powered by Savane 3.5