patchGNU Octave - Patches: patch #8464, Make lssa clang compliant (that...

 
 

patch #8464: Make lssa clang compliant (that is, make it correct C++).

Submitted by:  None
Submitted on:  Sun 18 May 2014 06:32:52 PM UTC  
 
Category: NonePriority: 5 - Normal
Status: In ProgressPrivacy: Public
Assigned to: NoneOriginator Email: -unavailable-
Open/Closed: Open

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Mon 19 May 2014 05:40:48 PM UTC, comment #1:

Your patch might be technically correct, but the commit message is a bit too pithy.

How about instead something like

Your username in the patch is also rather nonstandard. Do you prefer that username instead of your full name followed by an email address? Is this username what you set in your ~/.hgrc?

You can further amend your patch by editing files and doing

One further point: have you profiled this to ensure this doesn't result in a slowdown? It calls a ctor and dtor on each iteration of a loop, doesn't it? There might be a better approach.

I hope my review of your patch does not cause you any undue burden.

Jordi GutiƩrrez Hermoso <jordigh>
Project Administrator
Sun 18 May 2014 06:32:52 PM UTC, original submission:

If compiling the package lssa with clang, it quits with an error. The problem is that in strict C++, the functions "real" and "image" in std::complex do not return lvalues. gcc relaxes the rules and allows them to be lvalues, but clang doesn't.

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #31401:  stephens-patch-for-fixing-octave.diff added by None (3kB - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by jordigh (Posted a comment)
  • -unavailable- added by None (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 2 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Mon 19 May 2014 05:40:48 PM UTCjordighStatusNone=>In Progress
    Sun 18 May 2014 06:32:52 PM UTCNoneAttached File-=>Added stephens-patch-for-fixing-octave.diff, #31401

    Back to the top


    Powered by Savane 3.1-cleanup