patchGNU Octave - Patches: patch #8320, [mapping package] Conversion...

 
 

patch #8320: [mapping package] Conversion between units of length

Submitter:  Eugenio Gianniti <eg123>
Submitted:  Fri 21 Feb 2014 11:44:05 PM UTC
   
 
Category:  None Priority:  5 - Normal
Status:  Done Privacy:  Public
Assigned to:  None Open/Closed:  Closed
* Mandatory Fields

Add a New Comment Rich Markup
   

Sun 23 Feb 2014 05:51:24 PM UTC, comment #4: 

Perfect, thank you.

Eugenio Gianniti <eg123>
Sun 23 Feb 2014 05:29:21 PM UTC, comment #3: 

I have pushed your patches. You may need to strip your local changes and pull the repository again, since I merged the first two commits and slightly edited their commit messages.

Carnë Draug <carandraug>
Group Member
Sat 22 Feb 2014 11:10:46 PM UTC, comment #2: 

You are right, I appreciate your thoughtfulness.

As you suggested I added the functions to NEWS and INDEX. Moreover I added tests to check the conversion of vectors and matrices, but I can't think of anything else that could be troublesome and should be verified.

I hope it is good to get started!

Eugenio Gianniti <eg123>
Sat 22 Feb 2014 07:53:53 PM UTC, comment #1: 

At a first glance, I don't see anything wrong with the patch.

I believe you are an applicant to GSoC trying to get acquainted with Octave by taking items from the Short projects page, so I'd suggest you could prepare two more csets on top of this one.

One to change the NEWS and INDEX file to make reference of the new functions. See for example, csets 92dd0071c58d and f7c6d8890730, that also add new functions to this files.

On other to add a few extra tests to convert values in a vector and ND matrix. Something like:


%!test
%! km = [1.8520    3.7040    5.5560    7.4080    9.2600   11.1120];
%! nm = [1 2 3 4 5 6];
%! assert (km2nm (km), nm)
%! km = reshape (km, [1 3 2])
%! nm = reshape (nm, [1 3 2])
%! assert (km2nm (km), nm)


Of course, any more tests you can think of are welcome.

Carnë Draug <carandraug>
Group Member
Fri 21 Feb 2014 11:44:05 PM UTC, original submission:  

I added a group of missing functions for the conversion between units of length:

  * km2nm
  * km2sm
  * nm2km
  * nm2sm
  * sm2km
  * sm2nm

Each of them makes use of the unitsratio.m utility provided by the package and includes a test.

Eugenio Gianniti <eg123>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #30644:  patch_8320_2cset.diff added by eg123 (981B - application/octet-stream)
file #30645:  patch_8320_3cset.diff added by eg123 (3KiB - application/octet-stream)
file #30635:  length_units_conversion.diff added by eg123 (9KiB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by eg123 (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 5 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2014-02-23 carandraug StatusNone Done
        Open/ClosedOpen Closed
    2014-02-22 eg123 Attached File- Added patch_8320_2cset.diff, #30644
        Attached File- Added patch_8320_3cset.diff, #30645
    2014-02-21 eg123 Attached File- Added length_units_conversion.diff, #30635

    Back to the top

    Powered by Savane 3.13-f8d8.
    Corresponding source code