patchGNU Octave - Patches: patch #8273, functions needing tests

 
 

patch #8273: functions needing tests

Submitted by:  Mike Sander <msander>
Submitted on:  Tue 14 Jan 2014 02:13:10 AM UTC  
 
Category: NonePriority: 5 - Normal
Status: NonePrivacy: Public
Assigned to: NoneOpen/Closed: Open

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Tue 14 Jan 2014 04:02:24 AM UTC, comment #3:

try 2. this only includes scripts/testfun/ changes. untested_functions_patch02.diff

(file #30269)

Mike Sander <msander>
Tue 14 Jan 2014 03:08:02 AM UTC, comment #2:

ok regarding the single line test.

yeah, i screwed up with hg for display. i did not intend to include those changes yet. i was trying to outline (for myself) some tests to write.

i did the commit from within scripts/testfun/. i was not expecting the display changes to be included. hg noob. i guess i should have asked for advice.

Mike Sander <msander>
Tue 14 Jan 2014 02:45:24 AM UTC, comment #1:

What are the tests that you added to display.m supposed to be testing? I don't see how they test the display function.

Instead of writing

please write

as that is an equivalent one-line test and is consistent with what is used in other internal functions to mark them as not needing a separate set of tests.

John W. Eaton <jwe>
Project Administrator
Tue 14 Jan 2014 02:13:10 AM UTC, original submission:

i checked on irc. they recommended to submit here vs bug tracker.

this patch adds:
1 empty tests in scripts/testfun/
2 some initial tests in general/display.m

is it possible to keep this item open? i intend to submit more patches as i add tests for other untested functions.

Mike Sander <msander>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by jwe (Posted a comment)
  • -unavailable- added by msander (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 2 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Tue 14 Jan 2014 04:02:24 AM UTCmsanderAttached File-=>Added untested_functions_patch02.diff, #30269
    Tue 14 Jan 2014 02:13:11 AM UTCmsanderAttached File-=>Added untested_functions_patch01.diff, #30268

    Back to the top


    Powered by Savane 3.1-cleanup