patchGNU Octave - Patches: patch #8141, signal package: levinson.m deal...

 
 

patch #8141: signal package: levinson.m deal with matrix input (matlab compatibility)

Submitted by:  None
Submitted on:  Wed 31 Jul 2013 02:17:58 PM UTC  
 
Category: NonePriority: 5 - Normal
Status: Need InfoPrivacy: Public
Assigned to: Mike Miller <mtmiller>Originator Email: -unavailable-
Open/Closed: Open

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Thu 01 Aug 2013 04:17:05 AM UTC, comment #2:

Thanks Mike for having a look at it. Sorry for the problems applying it.

I just recently dug this up. I tried submitting a few years back but I think it got lost in the shuffle.

I will try and get the octave source checked out next week and get an updated patch with some better testing on it. Stay tuned.

Joe Romano <jromano>
Thu 01 Aug 2013 04:02:52 AM UTC, comment #1:

Hi, thanks for your contribution to the signal package. I can incorporate this as is, but it needs some clean up. Would you be willing to look at the following and post an updated patch?

  • Can you submit this in the form of a mercurial changeset against the current signal package repository, including a proper commit message? The attached patch does not apply cleanly for me.
  • Prefer columns(x) to size(x,2).
  • Make sure the function still works on row vectors, I think your patch inadvertently breaks that.
Mike Miller <mtmiller>
Project MemberIn charge of this item.
Wed 31 Jul 2013 02:17:58 PM UTC, original submission:

The Octave version of levinson.m does not have the ability to handle matrices with multiple columns of input data for the first input argument. As noted in the matlab documentation a matrix input should be handled by picking off each column of the input and processing it separately. The change was simple enough to make the existing levinson.m Octave function handle this case.

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #28722:  levinson.patch added by None (2kB - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by jromano (Posted a comment)
  • -unavailable- added by mtmiller (Posted a comment)
  • -unavailable- added by None (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 4 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Thu 01 Aug 2013 04:02:52 AM UTCmtmillerStatusNone=>Need Info
      Assigned toNone=>mtmiller
      Summarysingal package: levinson.m deal with matrix input (matlab compatibility)=>signal package: levinson.m deal with matrix input (matlab compatibility)
    Wed 31 Jul 2013 02:17:58 PM UTCNoneAttached File-=>Added levinson.patch, #28722

    Back to the top


    Powered by Savane 3.1-cleanup