patchGNU Octave - Patches: patch #8040, Agora: process newly uploaded...

 
 

patch #8040: Agora: process newly uploaded bundles

Submitted by:  Ahsan <ahsan>
Submitted on:  Thu 02 May 2013 08:33:53 PM UTC  
 
Category: NonePriority: 5 - Normal
Status: InvalidPrivacy: Public
Assigned to: NoneOpen/Closed: Closed

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Fri 21 Jun 2013 07:50:21 PM UTC, comment #3:

It doesn't look to me like this is the right kind of patch. I consulted with Wendy, and she agrees. The library dependency management for Agora should be handled by pip.

Jordi GutiƩrrez Hermoso <jordigh>
Project Administrator
Thu 02 May 2013 09:04:45 PM UTC, comment #2:

yeah its "python-magic" library.It is there in the pip_requirements. But the magic objects "constructor" needs explicit path to the "magic" file.So we need to copy the "magic" files to share folder and reference it in the code.
And yes I did not run this in virtual environment.
I need to further look at the links if there is any other fix present.

Ahsan <ahsan>
Thu 02 May 2013 08:49:06 PM UTC, comment #1:

Which magic library? Shouldn't this be handled as part of the pip_requirements? Are you not running this in a virtual environment?

The Agora source code doesn't ship its dependencies. They are meant to be managed with pip and virtualenv. Here is a series of blog posts from the last person who worked on this code:

http://dellsystem.me/archives#agora

In order to send patches to Agora, you should send Mercurial patches. Create a commit and export it. Here are some rough instructions to do so:

http://www.gnu.org/software/octave/doc/interpreter/Basics-of-Generating-a-Changeset.html#Basics-of-Generating-a-Changeset
http://jordi.inversethought.com/blog/how-to-write-a-patch-for-octave/

These instructions are for Octave proper, but they can be easily adapted to Agora. You may be more lax with your commit messages than what we do for Octave, but try to to keep them reasonable.

Jordi GutiƩrrez Hermoso <jordigh>
Project Administrator
Thu 02 May 2013 08:33:53 PM UTC, original submission:

Patch Details:

***Purpose: Fixes the problem that the Agora website does not process the newly uploaded bundle files. This patch fixes this problem and now newly uploaded bundles are processed correctly.
***The Reason:
The magic library is a wrapper around libmagic. Some files were missing of magic library. I have added those files. Moreover , I have modified the code in the tasks.py file in the bundle app.
***How the fix should be applied:
extract the fix_bundle.zip and put the folder into the root directory such that the "share" folder can be seen in the root directory with path 'share\' . When asked for the file 'tasks.py' to be overwritten, overwrite it. Make sure that the file "tasks.py" located in "\apps\bundle\" is overwritten.

Ahsan <ahsan>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #28000:  fix_bundle.zip added by ahsan (283kB - application/zip)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by jordigh (Posted a comment)
  • -unavailable- added by ahsan (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 5 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Fri 21 Jun 2013 07:50:21 PM UTCjordighPriority7 - High=>5 - Normal
      StatusNone=>Invalid
      Open/ClosedOpen=>Closed
    Mon 20 May 2013 04:13:59 PM UTCcarandraugSummaryAgora =>Agora: process newly uploaded bundles
    Thu 02 May 2013 08:33:53 PM UTCahsanAttached File-=>Added fix_bundle.zip, #28000

    Back to the top


    Powered by Savane 3.1-cleanup