patchGNU Octave - Patches: patch #8017, Add mainwindow Clear Command...

 
 

patch #8017: Add mainwindow Clear Command Window implementation

Submitter:  John Donoghue <lostbard>
Submitted:  Sat 13 Apr 2013 09:41:40 PM UTC
   
 
Category:  None Priority:  5 - Normal
Status:  Done Privacy:  Public
Assigned to:  None Open/Closed:  Closed
* Mandatory Fields

Add a New Comment Rich Markup
   

Jump to the original submission

Mon 22 Apr 2013 06:34:47 PM UTC, comment #6: 

I think clc and Ctrl-l and the clear workspace button are working correctly now with the following changeset:

http://hg.savannah.gnu.org/hgweb/octave/rev/106a38d7b396

so I'm closing this report.

John W. Eaton <jwe>
Group administrator
Mon 15 Apr 2013 03:44:25 AM UTC, comment #5: 

According to Matlab, clc clears all input and output from the command window, and makes it so that the history of scrolling/scrollbars are no longer available.


John Donoghue <lostbard>
Group Member
Sat 13 Apr 2013 10:43:19 PM UTC, comment #4: 

I should add that this is the behavior I'm seeing with the Unix terminal widget.  With the Windows terminal widget, the command window is closed and all previous contents are erased.  I'm not sure that's the best behavior either.

John W. Eaton <jwe>
Group administrator
Sat 13 Apr 2013 10:37:53 PM UTC, comment #3: 

Also, I'm now seeing that the command window is cleared by inserting blank lines.  For me, this is the behavior with Ctrl-l or clc.  Is that the behavior we want?

John W. Eaton <jwe>
Group administrator
Sat 13 Apr 2013 10:25:13 PM UTC, comment #2: 

After pushing, I noticed that it clears the window but leaves a blank line above the prompt, unlike running clc from the command line.  Hmm.  I guess that is the effect of jumping out of readline to force a redisplay?  Then I noticed that the command_editor::interrupt function has a bad side effect.  If there is some input already present on the line, it will be evaluated.  Since that can be an incomplete line, you can end up with a syntax error when all you want to do is clear the screen or step in the debugger.

Maybe there is another way we can do this job.

John W. Eaton <jwe>
Group administrator
Sat 13 Apr 2013 09:57:40 PM UTC, comment #1: 

Thanks, I pushed this changeset.

John W. Eaton <jwe>
Group administrator
Sat 13 Apr 2013 09:41:40 PM UTC, original submission:  

Patch to implment the functionality of the currently disabled Clear Command Window action.


John Donoghue <lostbard>
Group Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #27861:  mainwin_clearcommand_menu.diff added by lostbard (3KiB - text/x-patch - Clear Command Window patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by jwe (Posted a comment)
  • -email is unavailable- added by lostbard (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 3 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2013-04-22 jwe StatusNone Done
        Open/ClosedOpen Closed
    2013-04-13 lostbard Attached File- Added mainwin_clearcommand_menu.diff, #27861

    Back to the top

    Powered by Savane 3.13-caa5.
    Corresponding source code