patchGNU Octave - Patches: patch #8005, Added context menu to workspace...

 
 

patch #8005: Added context menu to workspace variable display

Submitter:  John Donoghue <lostbard>
Submitted:  Sun 07 Apr 2013 07:20:48 PM UTC
   
 
Category:  None Priority:  5 - Normal
Status:  Done Privacy:  Public
Assigned to:  None Open/Closed:  Closed
* Mandatory Fields

Add a New Comment Rich Markup
   

Jump to the original submission

Tue 09 Apr 2013 07:44:16 AM UTC, comment #7: 

I checked in your changes followed by another changeset with some style fixes.

Thanks for doing this, it looks much better to me now.

John W. Eaton <jwe>
Group administrator
Tue 09 Apr 2013 03:40:46 AM UTC, comment #6: 

Initial patch to make a table instead of tree attached (do I need to make a new patch submission?)


(file #27822)

John Donoghue <lostbard>
Group Member
Mon 08 Apr 2013 04:33:40 PM UTC, comment #5: 

I checked in my changes:

http://hg.savannah.gnu.org/hgweb/octave/rev/0f143f68078d

Would it be difficult to make the workspace view use a table instead of the tree view thing?  I don't think it adds much to have the separate collapsable lists for local/global/persistent.  We are almost always looking at the top-level symbol table which can't have persistent values and it seems to me that it would make more sense to add a separate column to indicate global status.

John W. Eaton <jwe>
Group administrator
Sun 07 Apr 2013 09:26:34 PM UTC, comment #4: 

ok - I will readd my fix when you are completed.

John Donoghue <lostbard>
Group Member
Sun 07 Apr 2013 08:55:02 PM UTC, comment #3: 

OK, I'll let you know when I'm done.  I'm trying to rework the workspace_view/model to avoid using the event listener thing, similar to what I've done for the other widgets.  I might not be done with that until tomorrow.

John W. Eaton <jwe>
Group administrator
Sun 07 Apr 2013 08:12:41 PM UTC, comment #2: 

The intent was that clicking anywhere in the row of a variable would allow selection of the menu, however it would always select the variable name.

I will take a look at the menu after your changes have come in and fix it.

John Donoghue <lostbard>
Group Member
Sun 07 Apr 2013 07:54:23 PM UTC, comment #1: 

Thanks for the patch.  I noticed a few odd things after applying it.  For example, the plot/disp/stem are available for all columns of the workspace viewer, not just the variable name.  Should they be?  That only seems to work when applied to the variable name.

In any case, I committed this patch because I'm about to make some changes to the workspace view and model that will probably make the patch not apply cleanly, so it seemed better to apply it now and fix it later.



John W. Eaton <jwe>
Group administrator
Sun 07 Apr 2013 07:20:48 PM UTC, original submission:  

Added context menu to the workspace variables for common commands that may be executed on them, similar to matlab functionality.


John Donoghue <lostbard>
Group Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #27822:  workspace_table.diff added by lostbard (17KiB - text/x-patch - workspace table implmentation)
file #27806:  workspace_ctxmenu.diff added by lostbard (4KiB - text/x-patch - context menu patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by jwe (Posted a comment)
  • -email is unavailable- added by lostbard (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2013-04-09 jwe StatusNone Done
        Open/ClosedOpen Closed
    2013-04-09 lostbard Attached File- Added workspace_table.diff, #27822
    2013-04-07 lostbard Attached File- Added workspace_ctxmenu.diff, #27806

    Back to the top

    Powered by Savane 3.13-02a9.
    Corresponding source code