patchGNU Octave - Patches: patch #8000, Added Filesdockwidget recently...

 
 

patch #8000: Added Filesdockwidget recently viewed directory pulldownlist

Submitter:  John Donoghue <lostbard>
Submitted:  Sat 06 Apr 2013 05:19:37 AM UTC
   
 
Category:  None Priority:  5 - Normal
Status:  Done Privacy:  Public
Assigned to:  None Open/Closed:  Closed
* Mandatory Fields

Add a New Comment Rich Markup
   

Jump to the original submission

Thu 11 Apr 2013 08:19:22 PM UTC, comment #8: 

It turned out that the file browser should not always be synchronized to the octave directory. I therefore pushed the first version of this patch, i.e. the one with separate mru-lists:
http://hg.savannah.gnu.org/hgweb/octave/rev/605d7f0ee0d8

Thanks for the patch and please excuse the additional work.

Torsten Lilge <ttl>
Group Member
Sun 07 Apr 2013 09:37:19 AM UTC, comment #7: 

The last patch works fine now, thanks. I am waiting for the discussion in the maintainers list before pushing it.

Torsten Lilge <ttl>
Group Member
Sun 07 Apr 2013 04:59:19 AM UTC, comment #6: 

I'm not sure what the behavior should be for the file browser window.

Your change makes it so that moving around in the file browser also changes the current working directory for Octave.  Is that the behavior we want?  I think of file browsing as independent of what the curent working directory is.  It seems to me we should only change the current working directory if some explicit action is taken in the file browser.

Maybe we should discuss this on the maintainers list before making more changes.

John W. Eaton <jwe>
Group administrator
Sat 06 Apr 2013 06:05:55 PM UTC, comment #5: 

whoops - must have exported twice to the ptach - patch reattached.

(file #27796)

John Donoghue <lostbard>
Group Member
Sat 06 Apr 2013 06:02:43 PM UTC, comment #4: 

New patch attached.

- fixed compile error - a left over from my first patch.
 
- fixed the issue with the up button, file name edit etc with your emit displayed_directory_changed line in 2 places.

- A QLineEdit field shouldnt be required as when the combobox is made editable, it should create one itself internally, which we then use to connect to the returnPressed signal.

Let me know if it still doesnt work.

(file #27795)

John Donoghue <lostbard>
Group Member
Sat 06 Apr 2013 03:53:54 PM UTC, comment #3: 

There are some issues with the new patch (the last one is partly an already existing problem as I found out while testing):

  • compilation stops with



src/files-dockwidget.cc:61:35: error: 'MaxMRUDirs' was not declared in this scope


Is this line necessary when the model of the main-window is used?

  • Editing the entry of the box and hitting return does not update the directory (In the main window a LineEdit in used in combination with a combo box).


  • the "up" button changes the directory in the files-dock-widget but does not update the combo-box (this is new) and does not update the octave-directory (this problem already exists).

Adding


emit displayed_directory_changed (dir.absolutePath ());

 
into files_dock_widget::change_directory_up () seems to solve this problem.

Torsten Lilge <ttl>
Group Member
Sat 06 Apr 2013 01:15:31 PM UTC, comment #2: 

You are probally right - i will retake a look

John Donoghue <lostbard>
Group Member
Sat 06 Apr 2013 12:59:55 PM UTC, comment #1: 

I think the entries of this new combo box would be the same as the ones of the main windows combo box. Should the file dock widget just display the list from the main windows combo box instead of managing a separate list?

Torsten Lilge <ttl>
Group Member
Sat 06 Apr 2013 05:19:37 AM UTC, original submission:  

Modification to the filesdockwidget to change directory path line edit to a editable combobox, allowing previous directories to be selectable from the list.


John Donoghue <lostbard>
Group Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #27796:  filelist_combo3.diff added by lostbard (6KiB - text/x-patch - Fixed compile error, and edit issues patch)
file #27795:  filelist_combo2.diff added by lostbard (12KiB - text/x-patch)
file #27792:  filelist_combo1.diff added by lostbard (6KiB - text/x-patch - New patch, using the main-window model for the current directory combobox)
file #27786:  filelist_combo.diff added by lostbard (5KiB - text/x-patch - Filesdockwidget recently viewed directory pulldownlist patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by jwe (Posted a comment)
  • -email is unavailable- added by ttl (Posted a comment)
  • -email is unavailable- added by lostbard (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 6 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2013-04-11 ttl StatusNone Done
        Open/ClosedOpen Closed
    2013-04-06 lostbard Attached File- Added filelist_combo3.diff, #27796
    2013-04-06 lostbard Attached File- Added filelist_combo2.diff, #27795
    2013-04-06 lostbard Attached File- Added filelist_combo1.diff, #27792
    2013-04-06 lostbard Attached File- Added filelist_combo.diff, #27786

    Back to the top

    Powered by Savane 3.13-caa5.
    Corresponding source code