patchGNU Octave - Patches: patch #7991, Remove _terminal pointer from...

 
 

patch #7991: Remove _terminal pointer from main_window.

Submitter:  Dan Sebald <sebald>
Submitted:  Tue 02 Apr 2013 08:53:35 PM UTC
   
 
Category:  None Priority:  5 - Normal
Status:  Done Privacy:  Public
Assigned to:  None Open/Closed:  Closed
* Mandatory Fields

Add a New Comment Rich Markup
   

Wed 03 Apr 2013 04:20:32 AM UTC, comment #1: 

Thanks for looking at this.  I checked in the changeset with a few minor changes.

When writing changelog entries in the future, unless there is something really unusual going on, please write what changed and not so much why.  If some explanation is needed, I think it is better to put that in comments in the code rather than in a changelog entry.

Also, although it is tempting to clean out cruft at the same time as making other changes, it would help if in the future those changes are made separately.  I much prefer to have mutliple changesets that each have one purpose rather than one changeset that does multiple kinds of changes.

Thanks,

jwe

John W. Eaton <jwe>
Group administrator
Tue 02 Apr 2013 08:53:35 PM UTC, original submission:  

This is a GUI related changeset to remove the _terminal variable from main_window.  Because the object _terminal is pointed to is contained by the dock widget and later deleted by that dock widget, the design should not need to retain QTerminal pointer.  Instead, the patch connects some more signals and slightly rearranges things so that the main_window doesn't need to maintain the contents of the QTerminal.  That responsibility is shifted to a new file QTerminal.cc.

I've also cleaned out some cruft.  Many of the public member functions of main_window were obviated with previous changes to the way signalling was improved.  E.g., no more "get_history" and that sort of thing.

In several locations I've removed the

 // FIXME -- what should happen if settings is 0?

predicament.

I've tested that the terminal settings still have an effect on the appearance of the terminal.

Dan Sebald <sebald>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #27749:  octave-remove_terminal_pointer-2013apr02.patch added by sebald (21KiB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by jwe (Posted a comment)
  • -email is unavailable- added by sebald (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 3 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2013-04-03 jwe StatusNone Done
        Open/ClosedOpen Closed
    2013-04-02 sebald Attached File- Added octave-remove_terminal_pointer-2013apr02.patch, #27749

    Back to the top

    Powered by Savane 3.13-caa5.
    Corresponding source code