patchGNU Octave - Patches: patch #7939, Add stem and leaf plot and

 
 

patch #7939: Add stem and leaf plot and

Submitted by:  Michael Godfrey <godfrey>
Submitted on:  Mon 04 Feb 2013 01:30:08 AM UTC  
 
Category:  None Priority:  5 - Normal
Status:  Done Privacy:  Public
Assigned to:  None Open/Closed:  Closed

Add a New Comment (Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

( Jump to the original submission)

Wed 06 Feb 2013 06:40:44 PM UTC, comment #10: 

Yet again, thanks!

Michael Godfrey <godfrey>
Project Member
Wed 06 Feb 2013 06:09:59 PM UTC, comment #9: 
Jordi Gutiérrez Hermoso <jordigh>
Project Administrator
Wed 06 Feb 2013 05:59:00 PM UTC, comment #8: 

Oops.  You are right.  I forgot the plot.txi patch.

Jordi,

Since Dan provided the diff below, could you
just push it?

Sorry about the oversight.

Michael Godfrey <godfrey>
Project Member
Wed 06 Feb 2013 05:56:45 PM UTC, comment #7: 

Michael had the proper lines in the original patch but must have forgotten to move it into his consolidated patch.  It is the lines

diff -r 352ef2fb3ad1 -r cfaf72792070 doc/interpreter/plot.txi
--- a/doc/interpreter/plot.txi  Sat Feb 02 15:30:53 2013 -0800
+++ b/doc/interpreter/plot.txi  Sun Feb 03 17:36:28 2013 -0500
@@ -136,6 +136,10 @@

 @DOCSTRING(hist)

+@DOCSTRING(stemleaf)
+
+@DOCSTRING(printd)
+
 @DOCSTRING(stairs)

 @DOCSTRING(stem)

that didn't make it in. 

Dan Sebald <sebald>
Wed 06 Feb 2013 05:51:52 PM UTC, comment #6: 

The DOCSTRINGs do the work for something this simple!
Maybe I will add some to the Manual if people seem
interested in more detail.

OK?

Michael Godfrey <godfrey>
Project Member
Wed 06 Feb 2013 05:43:26 PM UTC, comment #5: 

Your commit doesn't touch any files from the manual:

http://hg.savannah.gnu.org/hgweb/octave/rev/369b173d6c16

Was this an oversight?

Jordi Gutiérrez Hermoso <jordigh>
Project Administrator
Wed 06 Feb 2013 05:36:16 PM UTC, comment #4: 

Thanks very much for the style improvements.  I will
try to remember at least " and ##.

>Certainly. Would you like to prepare another patch? We also need >to
>find the proper location to include this new function into the >manual.
>It doesn't get added automatically, the manual needs a >DOCSTRING()
>macro to include it.


You may have misunderstood this comment.  The documentation for
stemleaf() and printd() was included in the changeset, including
the DOCSTRINGs and the update of module.mk

What I meant to say is that the current manual does not explain
how to introduce new files such as these.  It took a while
to figure out that just putting in the DOCSTRING's was not
enough (Dan Sebold actually figured it out, including the
fact that after updating module.mk, ./bootstrap is required.).

Would the "Contributing Guidelines" Section be a good place
for this?  Or is there other documention that goes into such
details?

Michael Godfrey <godfrey>
Project Member
Wed 06 Feb 2013 04:18:56 PM UTC, comment #3: 

Thanks, pushed and merged, with some style fixes that I hope you don't
mind:

    http://hg.savannah.gnu.org/hgweb/octave/graph/a60b6911842c

> Some documentation on what needs to be done when files (like
> module.mk) are updated would be helpful. Should this go in the
> Contributing Guidlines section of the Manual?


Certainly. Would you like to prepare another patch? We also need to
find the proper location to include this new function into the manual.
It doesn't get added automatically, the manual needs a DOCSTRING()
macro to include it.

Jordi Gutiérrez Hermoso <jordigh>
Project Administrator
Wed 06 Feb 2013 01:13:52 AM UTC, comment #2: 

Attached is a complete changeset which
provides the stem and leaf plot and a
supporting function (printd.m) which does
conversions of output to other formats, i.e.
pdf, ps eps, jpg.  This helps to make
it easier to arrange the stem and leaf plots
for inclusion in other documents.  It can
convert any object which is acceptable to disp().

After the changeset is applied it is necessary to
run ./bootstrap since it is bootstrap which uses
the updates scripts/plot/module.mk.  Dan Sebald
figured this out by searching through the code.
Some documentation on what needs to be done when
files (like module.mk) are updated would be helpful.
Should this go in the Contributing Guidlines section
of the Manual?

The attached changeset replaces all the previous ones.

(file #27399)

Michael Godfrey <godfrey>
Project Member
Mon 04 Feb 2013 05:52:45 AM UTC, comment #1: 

The attached 2 patches correct a few typos in the
patch below.  They should be applied as:

stemleaf_upd01.diff
then
stemleaf_upd02.diff

(file #27378, file #27379)

Michael Godfrey <godfrey>
Project Member
Mon 04 Feb 2013 01:30:08 AM UTC, original submission:  

changeset is attached.  It provides 2 functions
and edits plot.txi to include help documentation.

Additional docmentatyion for the Manual will follow when
I figure out how to do it.

Michael Godfrey <godfrey>
Project Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #27399:  stemleaf_20130205.diff added by godfrey (16KiB - text/x-patch)
file #27378:  stemleaf_upd01.diff added by godfrey (2KiB - text/x-patch)
file #27379:  stemleaf_upd02.diff added by godfrey (2KiB - text/x-patch)
file #27376:  stemleaf.diff added by godfrey (16KiB - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by sebald (Posted a comment)
  • -email is unavailable- added by jordigh (Posted a comment)
  • -email is unavailable- added by godfrey (Submitted the item)
  • -email is unavailable- added by godfrey
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

     

     

    Follow 7 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2013-02-06 jordigh StatusNone => Done
        Open/ClosedOpen => Closed
    2013-02-06 godfrey Attached File- => Added stemleaf_20130205.diff, #27399
    2013-02-04 godfrey Attached File- => Added stemleaf_upd01.diff, #27378
        Attached File- => Added stemleaf_upd02.diff, #27379
    2013-02-04 godfrey Attached File- => Added stemleaf.diff, #27376
        Carbon-Copy- => Added daniel.sebald@ieee.org

    Back to the top


    Powered by Savane 3.5