patchGNU Octave - Patches: patch #7874, Renaming unimplemented.m to...

 
 

patch #7874: Renaming unimplemented.m to __unimplemented__.m

Submitter:  Juan Pablo Carbajal <juanpi>
Submitted:  Wed 24 Oct 2012 10:09:41 PM UTC
   
 
Category:  None Priority:  5 - Normal
Status:  Done Privacy:  Public
Assigned to:  None Open/Closed:  Closed
* Mandatory Fields

Add a New Comment Rich Markup
   

Mon 29 Oct 2012 04:01:59 PM UTC, comment #5: 


> The renaming was closed with commit message
> "Close bad file rename"


> What was the problem?


When you moved one file, you recorded a deletion and an addition
instead of a renaming. This meant that it looks like the
_unimplemented_.m file looks like entirely your own creation, i.e.
it lost its history as inherited from unimplemented.m

To avoid this in the future, use the "hg rename" command so that hg is
aware of file renames, and turn on the git-style diff option in your
.hgrc:


[diff]
git = true


I fixed your commit to actually record the rename. Because a bad
commit had already been published, I closed the bad head so that
development could continue on the good one. After enabling the git
option in diff, compare the two commits:


hg export -r 77795b0ed263 ## Yours
hg export -r  ## Mine

## History as recorded by you
hg annotate -u -n -r 77795b0ed263 scripts/help/__unimplemented__.m

## History as recorded by me
hg annotate -u -n -r 8ed107220a3e scripts/help/__unimplemented__.m


Jordi GutiƩrrez Hermoso <jordigh>
Group Member
Sun 28 Oct 2012 06:17:42 AM UTC, comment #4: 

As of default branch de751531e548

The renaming was closed with commit message
"Close bad file rename"

What was the problem?

Thanks

Juan Pablo Carbajal <juanpi>
Group Member
Thu 25 Oct 2012 09:51:17 PM UTC, comment #3: 

I pushed a revised cset that correctly records the rename:

http://hg.savannah.gnu.org/hgweb/octave/rev/8ed107220a3e


Jordi GutiƩrrez Hermoso <jordigh>
Group Member
Thu 25 Oct 2012 08:22:21 PM UTC, comment #2: 

I tweaked your patches slightly to keep the list in module.mk and resource-manager.cc in alphabetical order.  I also added the changes that were made to each file into the Mercurial log.  The finished changeset was committed here (http://hg.savannah.gnu.org/hgweb/octave/rev/77795b0ed263)

Rik <rik5>
Group administrator
Wed 24 Oct 2012 10:41:45 PM UTC, comment #1: 

Forgot to modify scripts/help/module.mk

Here is the patch.

The change was done on top of the previous ones.


(file #26828)

Juan Pablo Carbajal <juanpi>
Group Member
Wed 24 Oct 2012 10:09:41 PM UTC, original submission:  

unimplemented.m is mean to be a private function but it has to be visible to path. To avoid that the user calls this functions unaware of this I rename the function _unimplemented_ following the instructions by Rik.

At the top level of the repository

$ grep -lr --include="*.m" unimplemented .
./scripts/pkg/private/parse_pkg_idx.m
./scripts/help/unimplemented.m
./scripts/io/importdata.m

However parse_pkg_idx.m importdata.m are false alarms, they do not call unimplemented.

$ grep -lr --include="*.cc" unimplemented .
./libgui/src/resource-manager.cc
./libinterp/interpfcn/variables.cc

In these two functions it was renamed accordingly

Juan Pablo Carbajal <juanpi>
Group Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #26827:  changeset_unimplemented.diff added by juanpi (19KiB - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by jordigh (Posted a comment)
  • -email is unavailable- added by rik5 (Posted a comment)
  • -email is unavailable- added by juanpi (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2012-10-25 rik5 StatusNone Done
        Open/ClosedOpen Closed
    2012-10-24 juanpi Attached File- Added changeset_unimplemented2.diff, #26828
    2012-10-24 juanpi Attached File- Added changeset_unimplemented.diff, #26827

    Back to the top

    Powered by Savane 3.13-02a9.
    Corresponding source code