patchGNU Octave - Patches: patch #7746, incomplete call to getarchprefix

 
 

patch #7746: incomplete call to getarchprefix

Submitted by:  Carnë Draug <carandraug>
Submitted on:  Mon 19 Mar 2012 01:45:55 AM UTC  
 
Category:  None Priority:  5 - Normal
Status:  Done Privacy:  Public
Assigned to:  None Open/Closed:  Closed

Add a New Comment (Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Thu 22 Mar 2012 10:41:56 AM UTC, comment #3: 
Carlo de Falco <cdf>
Project Member
Thu 22 Mar 2012 10:24:00 AM UTC, comment #2: 

I'm pretty sure it was not intended as it fails because of an
undefined variable global_install in getarchprefix.

`global_install' undefined near line 26 column 7
error: called from `getarchprefix' in file /home/carandraug/development/octave/scripts/pkg/private/getarchprefix.m near line 26, column 3
error: called from:
error:   /home/carandraug/development/octave/scripts/pkg/private/install.m at line 243, column 5
error:   /home/carandraug/development/octave/scripts/pkg/pkg.m at line 389, column 9

Also, this does not occur with the stable branch only on default so splitting it into several files must have changed something else.

Carnë Draug <carandraug>
Project Member
Thu 22 Mar 2012 03:00:07 AM UTC, comment #1: 

Carnë,

Thank you very much for looking into this!

The call to getarchprefix was not introduced by the recent
changes to pkg.m but it is there since the very beginning
when create_pkgadddel was introduced with this cset:

http://hg.savannah.gnu.org/hgweb/octave/rev/1401a79af68c

are you sure the behaviour was not intended? what error does
the present code produce?

c.

Carlo de Falco <cdf>
Project Member
Mon 19 Mar 2012 01:45:55 AM UTC, original submission:  

Hi

I was looking into the new organitzaion of the pkg and found a small bug. This is against the default branch. It's a really small thing.

Carnë

Carnë Draug <carandraug>
Project Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by rik5 (Updated the item)
  • -email is unavailable- added by cdf (Posted a comment)
  • -email is unavailable- added by carandraug (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

     

     

    Follow 3 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2012-07-11 rik5 StatusNone => Done
        Open/ClosedOpen => Closed
    2012-03-19 carandraug Attached File- => Added pkg-bugfix-create_pkgadddel.patch, #25398

    Back to the top


    Powered by Savane 3.5