patchGNU Octave - Patches: patch #7613, blkdiag.m compability with MATLAB

 
 

patch #7613: blkdiag.m compability with MATLAB

Submitter:  None
Submitted:  Thu 08 Sep 2011 02:59:20 PM UTC
   
 
Category:  None Priority:  3 - Low
Status:  None Privacy:  Public
Assigned to:  None Originator Email:  -email is unavailable-
Open/Closed:  Closed
* Mandatory Fields

Add a New Comment Rich Markup
   

Thu 08 Sep 2011 07:52:43 PM UTC, comment #4: 

Er, I meant to say, "... does indeed produce sparse output ..."

Jordi Gutiérrez Hermoso <jordigh>
Group Member
Thu 08 Sep 2011 07:51:13 PM UTC, comment #3: 

After confirming that Matlab does indeed produce output for blkdiag if any input is sparse, I have pushed the following:

http://hg.savannah.gnu.org/hgweb/octave/rev/c6601cb63e4e

I hope you agree this is the right fix, so I will be closing your patch submission. We can reopen it if your implementation has other improvements I didn't see.

Jordi Gutiérrez Hermoso <jordigh>
Group Member
Thu 08 Sep 2011 03:44:12 PM UTC, comment #2: 

I don't understand. What is wrong with our implementation? Is it incorrect for sparse matrices?

How about the proposed patch for our blkdiag implementation instead?

(file #23956)

Jordi Gutiérrez Hermoso <jordigh>
Group Member
Thu 08 Sep 2011 03:01:28 PM UTC, comment #1: 

The "ismatlab" logic can be removed. My ismatlab.m looks like:

function ismatlab = ismatlab
ismatlab = (5 == exist('matlabroot', 'builtin'));

Anonymous
Thu 08 Sep 2011 02:59:20 PM UTC, original submission:  

the attached blkdiag.m closers mimics the behavior of MATLAB. works with both sparse and full matrices as input, also mixed.

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #23956:  blkdiag.patch added by jordigh (2KiB - text/x-diff)
file #23955:  blkdiag.m added by None (632B - text/x-objcsrc)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by jordigh (Updated the item)
  • -email is unavailable- added by None (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 3 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2011-09-08 jordigh Open/ClosedOpen Closed
    2011-09-08 jordigh Attached File- Added blkdiag.patch, #23956
    2011-09-08 None Attached File- Added blkdiag.m, #23955

    Back to the top

    Powered by Savane 3.13-02a9.
    Corresponding source code