patchGNU Octave - Patches: patch #7588, synthesis.m fails when w_size=inc

 
 

patch #7588: synthesis.m fails when w_size=inc

Submitted by:  None
Submitted on:  Thu 28 Jul 2011 10:46:16 PM UTC  
 
Category: NonePriority: 5 - Normal
Status: DonePrivacy: Public
Assigned to: NoneOriginator Email: -unavailable-
Open/Closed: Closed

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Tue 22 Oct 2013 12:22:45 AM UTC, comment #2:

I overhauled the two functions stft and synthesis and incorporated the patch here (http://hg.savannah.gnu.org/hgweb/octave/rev/6ed0a8532bcf). This will be a part of the 3.8 release due in a few weeks.

Rik <rik5>
Project Administrator
Tue 20 Nov 2012 03:52:02 PM UTC, comment #1:

This one is not a proper mercurial changeset but the change is simple and seems correct to me.
No other m-file in octave is using synthesis so nothing is broken.

I checked using

grep -r --include=".m" synthesis\ \( .

Another story is the user's scripts. Maybe a note in NEWS can be added?

Juan Pablo Carbajal <juanpi>
Thu 28 Jul 2011 10:46:16 PM UTC, original submission:

For rectangular windows the signal can be fully reconstructed even when the window size is equal to the increment.

But synthesis fails with an error (invalid row index = 0). To reproduce run:

x=rand(1024,1);
[y,c]=stft(x,128,128,64,3);
x2=synthesis(y,c);
max(abs(x2-x)) % validate expected result

The attached patch fixes the problem but also affects synthesis so that the resulting signal starts earlier. Ie. previously this was fine

x=rand(1024,1);
[y,c]=stft(x);
x2=synthesis(y,c);
max(abs(x2-x(28:987))) % validate expected result

But with the patch this has to be changed to

x=rand(1024,1);
[y,c]=stft(x);
x2=synthesis(y,c);
max(abs(x2-x(29:988))) % validate expected result

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #23712:  synthesisfix.patch added by None (367B - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by rik5 (Posted a comment)
  • -unavailable- added by juanpi (Posted a comment)
  • -unavailable- added by None (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 3 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Tue 22 Oct 2013 12:22:45 AM UTCrik5StatusNone=>Done
      Open/ClosedOpen=>Closed
    Thu 28 Jul 2011 10:46:16 PM UTCNoneAttached File-=>Added synthesisfix.patch, #23712

    Back to the top


    Powered by Savane 3.1-cleanup