patchThe GNU Hurd - Patches: patch #6840, fix remaining extern inlines


You are not allowed to post comments on this tracker with your current authentication level.

patch #6840: fix remaining extern inlines

Submitted by:  Marc Dequènes (Duck) <duck>
Submitted on:  Sun 24 May 2009 12:09:39 PM UTC
Category:  other Hurd Priority:  5 - Normal
Status:  Done Privacy:  Public
Assigned to:  tschwinge Open/Closed:  Closed
Planned Release:  None
Wiki-like text discussion box: 

This was eventually fixed.

* Mandatory Fields

Add a New Comment (Rich Markup)

Comment Type & Canned Response:
       No canned response available


Wed 24 Jun 2009 07:36:53 PM UTC, comment #2: 

I pushed my proposed changes to the new master-fix_extern_inline branch.  Could you please review that and confirm that it works?

I have not yet tested this in a live system, but I did compare the compiled libraries and executables of the previous and this new version, and there were only -- as far as I can tell -- minor differences.

Thomas Schwinge <tschwinge>
Project Administrator
Sun 21 Jun 2009 04:49:04 PM UTC, comment #1: 

This patch conflicts with the usage of the header files in, e.g., libshouldbeinlibc/idvec-funcs.c.

I will now re-read the GCC inline documentation and try to figure out (a) what was meant to be done with respect to these, and (b) how that is to be achieved these days.

Thomas Schwinge <tschwinge>
Project Administrator
Sun 24 May 2009 12:09:39 PM UTC, original submission:  

This patch updates the extern inline definition for newer gcc. The work in glibc was done by youpi but a few things remained in the Hurd itself. youpi reviewed this patch already (he kindly mentored me). I was able to build xmlfs again, with -O0, -O2, and -Os successfully.

Marc Dequènes (Duck) <duck>


(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:

Attached Files
file #18191:  hurd_extern_inline_fix.patch added by duck (21KiB - text/x-diff)


Depends on the following items: None found

Items that depend on this one: None found


Carbon-Copy List
  • -email is unavailable- added by sthibaul (Updated the item)
  • -email is unavailable- added by tschwinge (Posted a comment)
  • -email is unavailable- added by tschwinge
  • -email is unavailable- added by duck (Submitted the item)

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.





    Follow 8 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2020-01-27 sthibaul StatusIn Progress => Done
        Open/ClosedOpen => Closed
        Wiki-like text discussion box => This was eventually fixed.
    2009-06-21 tschwinge CategoryNone => other Hurd
        StatusNone => In Progress
        Assigned toNone => tschwinge
        Carbon-Copy- => Added sthibaul
    2009-05-24 duck Attached File- => Added hurd_extern_inline_fix.patch, #18191

    Back to the top

    Powered by Savane 3.9