As I mentioned in the discourse thread (https://octave.discourse.group/t/wip-stack-vm-for-octave/2884/92) I pushed a series of changes based on the patches posted here.  Also as noted in the commit message for the last changeset (http://hg.savannah.gnu.org/hgweb/octave/rev/994b527e0ffe) when I first applied the VM changes I accidentally used the original patch posted here instead of the one posted to comment #3.  Changeset 994b527e0ffe updates Octave with the additional diffs present in the later patch file except for the object pool classes.  They don't appear to be required by the other changes and I think we should consider them separately.

I have updated the patch. ("octave_32196.patch")

Some problems are solved. E.g. warnings getting spammed in _run_test_suite_ as well as some more esoteric problems.

The build flag 'ENABLE_VM_EVALUATOR' doesn't do anything and the
user need to run '__enable_vm_eval__(1)' or use '__vm_compile' for the VM to run as discussed in the Discourse thread.


(file #54823)

Thank you for that patch.

I tried to build on Windows on top of a current head of the default branch (hg id 28ef2991fb5a):
It compiles fine and the built-in test suite (mostly) passes. 👍

However, I see a lot of warnings while running the test suite that I don't remember seeing before. Some of them are VM related (they mention not yet implemented features of the VM). But others seem to be unrelated afaict. E.g.:

  libinterp\parse-tree\pt-tm-const.cc-tst ........................warning: implicit conversion from numeric to char
warning: called from
    __test__ at line 2 column 1
    test    __run_test_suite__>run_test_dir at line 216 column 44
    __run_test_suite__>run_test_dir at line 180 column 40
    __run_test_suite__ at line 74 column 40
    D:/repo/Octave/octave-2/.build/../test/fntests.m at line 59 column 1

warning: implicit conversion from numeric to char
warning: called from
    __test__ at line 2 column 1
    test    __run_test_suite__>run_test_dir at line 216 column 44
    __run_test_suite__>run_test_dir at line 180 column 40
    __run_test_suite__ at line 74 column 40
    D:/repo/Octave/octave-2/.build/../test/fntests.m at line 59 column 1
[...]

Or:

  general\integral.m .............................................warning: quadcc: Error tolerance not met.  Estimated error: 6.0494e-07
 pass   34/34
  general\integral2.m ............................................warning: quadcc: Error tolerance not met.  Estimated error: inf
warning: quadcc: Error tolerance not met.  Estimated error: inf
warning: quadcc: Error tolerance not met.  Estimated error: inf
warning: quadcc: Error tolerance not met.  Estimated error: inf
 pass   50/50

The tests still pass though.

One actual test failure that seems to be new is also `warning` related:

>>>>> processing D:\repo\Octave\octave-2\test\struct.tst
***** error <invalid dot name structure assignment>
 c(4, 4, 4, 4).name  = "a";
 c(3, 3, 3, 3).value = 1;
 c([1, 3], 2, :, [3, 4]).value = 1;
!!!!! error failed.
Expected <invalid dot name structure assignment>, but got <invalid assignment to cs-list outside multiple assignment>

Is handling Octave warnings affected by the VM?

I didn't look into the changes in any detail. Just a rather "nitty" remark: We usually don't claim copyright for past years when new files are added.