patchGNU Octave - Patches: patch #10321, [octave forge] (communications)...

 
 

patch #10321: [octave forge] (communications) Implementation of ssbmod

Submitter:  azmat <azm999>
Submitted:  Sat 01 Apr 2023 07:51:51 AM UTC
   
 
Category:  Forge : new function Priority:  5 - Normal
Status:  Done Privacy:  Public
Assigned to:  None Open/Closed:  Closed
* Mandatory Fields

Add a New Comment Rich Markup
   

Mon 11 Dec 2023 01:31:56 PM UTC, comment #3: 

Closing report as completed.

Nicholas Jankowski <nrjank>
Group Member
Mon 03 Apr 2023 03:53:46 PM UTC, comment #2: 

Thanks, I improved and committed the new function at https://sourceforge.net/p/octave/communications/

Nir Krakauer <nir_krakauer>
Sat 01 Apr 2023 02:12:51 PM UTC, comment #1: 

Thanks for the contribution, I tagged the communications maintainer.


Just a quick look at the file in terms of visual rather than functionality a few comments:


Your copyright has a bad year 20203


The texinfo has some issues I think, type help ssbmod, to show the texingo as a user would see.

The additional function definitions after the initial deftypefn should be deftypefnx.

Instead of calling the optional varargin{1} and {2} in the documentation, use the actual functional name of the variable.

the varargs are also outside you inputs list currently.

You dont need to add basically the same documentation as a comment after the help text - if there is any additional information in it, include it in the help text (references etc)


The function has some test or demo comments at the bottom? but are not in a test block.



John Donoghue <lostbard>
Group Member
Sat 01 Apr 2023 07:51:51 AM UTC, original submission:  

hi Octave team,

this patch is for single side band modulation function implementation : ssbmod

I have followed the contribution guidelines but since it is my first contribution i think it might need a review.

please review and suggest any changes or correction if needed.

regards

azmat <azmat.dev0@gmail.com>

azmat <azm999>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #54546:  ssbmod.m added by azm999 (4KiB - text/x-objcsrc - <lostbard> thank you for your review I Fixed the issues you mentioned .)
file #54540:  ssbmod.m added by azm999 (4KiB - text/x-objcsrc)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by nrjank (Posted a comment)
  • -email is unavailable- added by nir_krakauer (Posted a comment)
  • -email is unavailable- added by lostbard (Posted a comment)
  • -email is unavailable- added by lostbard (communications maintailer)
  • -email is unavailable- added by azm999 (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 6 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2023-12-11 nrjank StatusNone Done
        Open/ClosedOpen Closed
        SummaryCommunications package : Implementation of ssbmod [octave forge] (communications) Implementation of ssbmod
    2023-04-02 azm999 Attached File- Added ssbmod.m, #54546
    2023-04-01 lostbard Carbon-Copy- Added nir_krakauer
    2023-04-01 azm999 Attached File- Added ssbmod.m, #54540

    Back to the top

    Powered by Savane 3.13-4b48.
    Corresponding source code