patchGNU Octave - Patches: patch #10241, WIP Remove null checks in...

 
 

patch #10241: WIP Remove null checks in tree_binary_expression

Submitter:  John W. Eaton <jwe>
Submitted:  Thu 23 Jun 2022 07:40:02 PM UTC
   
 
Category:  Core : other Priority:  5 - Normal
Status:  None Privacy:  Public
Assigned to:  None Open/Closed:  Open
* Mandatory Fields

Post a Comment

Add a New Comment Rich Markup
   

Discussion

Tue 07 Feb 2023 11:45:06 PM UTC, comment #2: 

Updated patch attached that takes recent changes to whitespace and (void) into account. Applies to 758de955caca.

(file #54323)

Arun Giridhar <arungiridhar>
Group Member
Wed 25 Jan 2023 06:08:32 PM UTC, comment #1: 

This patch removes two constructors that were calling "m_braindead_shortcircuit_warning_issued".

Since there is no function called "m_braindead_shortcircuit_warning_issued" any longer, should this entire patch be disregarded, or should only the replacement constructors be removed instead?

Arun Giridhar <arungiridhar>
Group Member
Thu 23 Jun 2022 07:40:02 PM UTC, original submission:  

From Petter Tomner <petter>, extracted from the zip file attached to the following comment in the discourse thread "WIP stack VM for Octave": https://octave.di ... or-octave/2884/10


John W. Eaton <jwe>
Group administrator

 

Attached Files

Attached Files
file #54323:  new_30623.patch added by arungiridhar (3.2KiB - text/x-patch)
file #53359:  octave_30623.patch added by jwe (3.8KiB - text/x-patch)

(Note: upload size limit is set to 4.0MiB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

 

Dependencies

This item does not depend on any other items.

No items depend on this one.

 

Mail Notification Carbon-Copy List

Carbon-Copy List
  • -email is unavailable- added by arungiridhar (Posted a comment)
  • -email is unavailable- added by jwe (Submitted the item)
  • -email is unavailable- added by jwe
  •  

    Votes

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

    History

    Follow 3 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2023-02-07 arungiridhar Attached File- Added new_30623.patch, #54323
    2022-06-23 jwe Attached File- Added octave_30623.patch, #53359
        Carbon-Copy- Added petter

    Back to the top

    Powered by Savane 3.16-a7ba.
    Corresponding source code