bugGNU Octave - Bugs: bug #65645, Execute FIXME of perms.cc: Use...

 
 

bug #65645: Execute FIXME of perms.cc: Use constexpr instead of template specialisation

Submitter:  Hendrik K <koerhen>
Submitted:  Fri 26 Apr 2024 05:42:00 AM UTC
   
 
Category:  Interpreter Severity:  3 - Normal
Priority:  5 - Normal Item Group:  None
Status:  Fixed Assigned to:  None
Originator Name:  Open/Closed:  * Closed
Release:  * dev Operating System:  * Any
Fixed Release:  10.1.0 (current default) Planned Release:  10.1.0 (current default)
* Mandatory Fields

Add a New Comment Rich Markup
   

Sat 27 Apr 2024 12:25:04 PM UTC, comment #3: 

It looks like the changes are working as expected (at least no errors in the CI).

Thank you again for your contribution.

Closing as fixed.

Markus Mützel <mmuetzel>
Group administrator
Fri 26 Apr 2024 03:22:21 PM UTC, comment #2: 

Thank you for the contribution.

The patch looks reasonable to me.
I pushed it with minor changes to the default branch:
https://hg.savannah.gnu.org/hgweb/octave/rev/65cbf92800ed

Marking as ready for test.

Markus Mützel <mmuetzel>
Group administrator
Fri 26 Apr 2024 05:45:52 AM UTC, comment #1: 

A patch file is attached.


(file #55977)

Hendrik K <koerhen>
Fri 26 Apr 2024 05:42:00 AM UTC, original submission:  

With Octave 10 C++-17 has become mandatory. This enables executing the FIXME of perms.cc:

Use constexpr (requiring C++-17) instead of template specialization.


Hendrik K <koerhen>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #55977:  octave_65645.patch added by koerhen (2KiB - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by mmuetzel (Posted a comment)
  • -email is unavailable- added by koerhen (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only group members can vote.

     

    Follow 8 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2024-04-27 mmuetzel StatusReady For Test Fixed
        Open/ClosedOpen Closed
        Fixed ReleaseNone 10.1.0 (current default)
    2024-04-26 mmuetzel CategoryOctave Function Interpreter
        StatusNone Ready For Test
        Operating SystemGNU/Linux Any
        Planned ReleaseNone 10.1.0 (current default)
    2024-04-26 koerhen Attached File- Added octave_65645.patch, #55977

    Back to the top

    Powered by Savane 3.13-bb6a.
    Corresponding source code