GNU Astronomy Utilities - Bugs: bug #48453, A copy-paste error in the function...
You are not allowed to post comments on this tracker with your current authentication level.
bug #48453: A copy-paste error in the function dilate0_erode1_8con inside binary.c
Submitter: | Vladimir Markelov <vvm> | ||
Submitted: | Sat 09 Jul 2016 11:18:27 PM UTC | ||
Category: | NoiseChisel | Severity: | 2 - Minor |
Item Group: | Source code | Status: | Fixed |
Privacy: | Public | Assigned to: | vvm |
Open/Closed: | Closed |
Sat 23 Jul 2016 04:49:47 PM UTC, comment #3: |
Mohammad Akhlaghi <makhlaghi> |
Sun 10 Jul 2016 06:03:12 PM UTC, comment #2: This bug #48453 and support ticket sr #109074 (https://savannah.gnu.org/support/?109074) are the same.
|
Vladimir Markelov <vvm> |
Sat 09 Jul 2016 11:22:25 PM UTC, comment #1: I've pushed patch to my repository:
|
Vladimir Markelov <vvm> |
Sat 09 Jul 2016 11:18:27 PM UTC, original submission:
In the last 'if' one condition is check twice but another one is checked never.
|
Vladimir Markelov <vvm> |
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 5 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2016-07-23 | makhlaghi | Status | In Progress | Fixed | |
2016-07-23 | makhlaghi | Open/Closed | Open | Closed | |
2016-07-10 | vvm | Status | Fixed | In Progress | |
2016-07-09 | vvm | Status | None | Fixed | |
2016-07-09 | vvm | Attached File | - | Added chiesel_body.patch, #37790 |
Powered by Savane 3.13-bb6a.
Corresponding source code
(This reply is similar for bug #48453, bug #48516 and bug #48603)
Thanks a lot for these very accurate fixes! They certainly required a high-level of attention to detail. All three have now been merged with master and pushed to the main repository. After syncing your repository you can delete the branches in your online repository (so my next fetch from your fork will also remove the branches from my personal repository ;-)).
I would just be most grateful if future commits could apply these notes to make the Gnuastro version controlled history more uniform:
I also had a comment about the patches. Now that you have made a fork or Gnuastro, they might not be necessary for you any more, but I am just noting this for others who might read this.
If the patches are sent to us with Git's format-patch tool, you can directly send us commits (including your identification, date and a message):
https://git-scm.com/book/en/v2/Distributed-Git-Contributing-to-a-Project#Public-Project-over-Email
This will make your work fully registered in the version controlled history. The raw patches do not contain thi us information and it will thus be very hard for us to acknowledge your great contributions in the AUTHORS file and/or the PDF manual where all contributors arelisted.