bugGNU Astronomy Utilities - Bugs: bug #48516, Misleading error message in...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #48516: Misleading error message in sanitycheck function

Submitted by:  Vladimir Markelov <vvm>
Submitted on:  Fri 15 Jul 2016 02:12:10 AM UTC  
 
Category: CropSeverity: 2 - Minor
Item Group: Source codeStatus: Fixed
Privacy: PublicAssigned to: Vladimir Markelov <vvm>
Open/Closed: Closed

Sat 23 Jul 2016 04:52:20 PM UTC, comment #2:

(This reply is similar for bug #48453, bug #48516 and bug #48603)

Thanks a lot for these very accurate fixes! They certainly required a high-level of attention to detail. All three have now been merged with master and pushed to the main repository. After syncing your repository you can delete the branches in your online repository (so my next fetch from your fork will also remove the branches from my personal repository ;-)).

I would just be most grateful if future commits could apply these notes to make the Gnuastro version controlled history more uniform:

  • Start the commit message title with a capital letter.
  • Do not include the bug number in the title. It is included in some merge commit titles since they are just a merge and no change in the files has actually been done.
  • In one case (commit 70e7da4) the title was a little too long. Try to keep the titles within 50 characters ;-).
  • Try to be very descriptive in the commit body (even more than here on Savannah when reporting or fixing the bug). This is very important for others to be able to understand your work later (and also for the developers). For example I had to compare the code changes to the webpage/email to understand it. If you elaborate in the commit message, a "git log -p" will be enough for any developer to understand much more easier.
  • Add a "This fixed bug #XXXXX." or "This finishes task #ID." after the commit message body.

I also had a comment about the patches. Now that you have made a fork or Gnuastro, they might not be necessary for you any more, but I am just noting this for others who might read this.

If the patches are sent to us with Git's format-patch tool, you can directly send us commits (including your identification, date and a message):

https://git-scm.com/book/en/v2/Distributed-Git-Contributing-to-a-Project#Public-Project-over-Email

This will make your work fully registered in the version controlled history. The raw patches do not contain thi us information and it will thus be very hard for us to acknowledge your great contributions in the AUTHORS file and/or the PDF manual where all contributors arelisted.

Mohammad Akhlaghi <makhlaghi>
Project Administrator
Fri 15 Jul 2016 02:55:24 AM UTC, comment #1:

Please see the patch at my repository (branch):
https://github.com/VladimirMarkelov/gnuastro-vvm/tree/bug-48516-message-fix

Commit:
https://github.com/VladimirMarkelov/gnuastro-vvm/commit/2e3abf8e30805ec9c20574ff37c94085f46c8ae4

Vladimir Markelov <vvm>
Project MemberIn charge of this item.
Fri 15 Jul 2016 02:12:10 AM UTC, original submission:

src/imgcrop/ui.c
386 if(p->iwidth[0]<3)
387 error(EXIT_FAILURE, 0, "--iwidth has to be >3 pixels");

iwidth[0] must be less than 3 but the message says that it must be greater than 3. It seem the message should say '...to be 3 or more ...'

Vladimir Markelov <vvm>
Project MemberIn charge of this item.

 

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by makhlaghi (Posted a comment)
  • -unavailable- added by vvm (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 3 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sat 23 Jul 2016 04:52:20 PM UTCmakhlaghiStatusIn Progress=>Fixed
      Open/ClosedOpen=>Closed
    Fri 15 Jul 2016 02:55:24 AM UTCvvmStatusNone=>In Progress

    Back to the top


    Powered by Savane 3.1-cleanup1