bugGNU Astronomy Utilities - Bugs: bug #48603, The function sanitycheck inside...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #48603: The function sanitycheck inside ui.c will fail always if matrixname is not NULL

Submitted by:  Vladimir Markelov <vvm>
Submitted on:  Sat 23 Jul 2016 04:01:37 PM UTC  
 
Category: WarpSeverity: 2 - Minor
Item Group: Output not reasonableStatus: Fixed
Privacy: PublicAssigned to: None
Open/Closed: Closed

Mon 25 Jul 2016 12:42:08 AM UTC, comment #5:

Thanks for the very interesting suggestion Mose! I will certainly try it out next time.

Mohammad Akhlaghi <makhlaghi>
Project Administrator
Mon 25 Jul 2016 12:19:18 AM UTC, comment #4:

Mohammad, if you don't want to clutter your local repository with other people's branches, in the case of GitHub you can get a patch file for a given commit (or set of commits) by appending ".patch" to the URL. For example, for the commit https://github.com/VladimirMarkelov/gnuastro-vvm/commit/70e7da4d214696d0c827ce0733088791e96b0c77 the corresponding patch file is at https://github.com/VladimirMarkelov/gnuastro-vvm/commit/70e7da4d214696d0c827ce0733088791e96b0c77.patch There is also the ".diff" file, but probably the patch is more useful.

Mosè Giordano <giordano>
Project Member
Sat 23 Jul 2016 04:55:12 PM UTC, comment #3:

(This reply is similar for bug #48453, bug #48516 and bug #48603)

Thanks a lot for these very accurate fixes! They certainly required a high-level of attention to detail. All three have now been merged with master and pushed to the main repository. After syncing your repository you can delete the branches in your online repository (so my next fetch from your fork will also remove the branches from my personal repository ;-)).

I would just be most grateful if future commits could apply these notes to make the Gnuastro version controlled history more uniform:

  • Start the commit message title with a capital letter.
  • Do not include the bug number in the title. It is included in some merge commit titles since they are just a merge and no change in the files has actually been done.
  • In one case (commit 70e7da4) the title was a little too long. Try to keep the titles within 50 characters ;-).
  • Try to be very descriptive in the commit body (even more than here on Savannah when reporting or fixing the bug). This is very important for others to be able to understand your work later (and also for the developers). For example I had to compare the code changes to the webpage/email to understand it. If you elaborate in the commit message, a "git log -p" will be enough for any developer to understand much more easier.
  • Add a "This fixed bug #XXXXX." or "This finishes task #ID." after the commit message body.

I also had a comment about the patches. Now that you have made a fork or Gnuastro, they might not be necessary for you any more, but I am just noting this for others who might read this.

If the patches are sent to us with Git's format-patch tool, you can directly send us commits (including your identification, date and a message):

https://git-scm.com/book/en/v2/Distributed-Git-Contributing-to-a-Project#Public-Project-over-Email

This will make your work fully registered in the version controlled history. The raw patches do not contain thi us information and it will thus be very hard for us to acknowledge your great contributions in the AUTHORS file and/or the PDF manual where all contributors arelisted.

Mohammad Akhlaghi <makhlaghi>
Project Administrator
Sat 23 Jul 2016 04:01:37 PM UTC, comment #2:

This item has been reassigned from the project GNU Astronomy Utilities support tracker to your tracker.

The original report is still available at support #109075

Following are the information included in the original report:

[field #0] Item ID: 109075
[field #1] Group ID: 11425
[field #2] Open/Closed: Open
[field #3] Severity: 2 - Minor
[field #4] Privacy: Public
[field #8] : Unknown support Field Display Type
[field #9] Category: ImageWarp
[field #10] Submitted by: vvm
[field #11] Assigned to: vvm
[field #12] Submitted on: Wed 22 Jun 2016 11:46:47 AM JST
[field #13] Summary: The function sanitycheck inside ui.c will fail always if matrixname is not NULL
[field #14] Original Submission: The part of condition after checking p->up.matrixname is always true. But, according to error text it should fail only if the matrix is not square or any of its side does not equal 2 or 3.

Please,see my patch attached
[field #16] Item Group: Enhancement
[field #17] Status: In Progress
[field #18] Component Version: None
[field #19] Operating System: None
[field #20] Reproducibility: None
[field #21] Size (loc): None
[field #22] Fixed Release: None
[field #23] Planned Release: None
[field #24] Effort: 0.00
[field #28] Priority: 5 - Normal
[field #31] Percent Complete: 0%
[field #33] Release: None
[field #58] Custom Select Box #1: None
[field #59] Custom Select Box #2: None
[field #60] Custom Select Box #3: None
[field #61] Custom Select Box #4: None
[field #62] Custom Select Box #5: None
[field #63] Custom Select Box #6: None
[field #64] Custom Select Box #7: None
[field #65] Custom Select Box #8: None
[field #66] Custom Select Box #9: None
[field #67] Custom Select Box #10: None

Mohammad Akhlaghi <makhlaghi>
Project Administrator
Sun 10 Jul 2016 06:59:18 PM UTC, comment #1:

Please, see a patch at my repository.

Branch: https://github.com/VladimirMarkelov/gnuastro-vvm/tree/sr-109075-imagewarp

The commit: https://github.com/VladimirMarkelov/gnuastro-vvm/commit/70e7da4d214696d0c827ce0733088791e96b0c77

Vladimir Markelov <vvm>
Project Member
Sat 23 Jul 2016 04:01:37 PM UTC, original submission:

The part of condition after checking p->up.matrixname is always true. But, according to error text it should fail only if the matrix is not square or any of its side does not equal 2 or 3.

Please,see my patch attached

Vladimir Markelov <vvm>
Project Member

 

Attached Files
file #37540:  imgwarp.patch added by vvm (625B - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by giordano (Posted a comment)
  • -unavailable- added by makhlaghi (Posted a comment)
  • -unavailable- added by vvm (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 5 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sat 23 Jul 2016 04:55:12 PM UTCmakhlaghiCategoryNone=>Warp
      Item GroupNone=>Output not reasonable
      StatusNone=>Fixed
      Open/ClosedOpen=>Closed
    Sat 23 Jul 2016 04:01:37 PM UTCmakhlaghiReassign itemGNU Astronomy Utilities, sr #109075=>GNU Astronomy Utilities, bug #48603

    Back to the top


    Powered by Savane 3.1-cleanup1