bugGNU Octave - Bugs: bug #47672, patch with struct argument does...

 
 

bug #47672: patch with struct argument does not support uppercase letters in fields

Submitter:  Markus Mützel <mmuetzel>
Submitted:  Tue 12 Apr 2016 11:06:40 AM UTC
   
 
Category:  Octave Function Severity:  1 - Wish
Priority:  1 - Later Item Group:  Matlab Compatibility
Status:  Fixed Assigned to:  None
Originator Name:  Open/Closed:  * Closed
Release:  * dev Operating System:  * Any
Fixed Release:  None Planned Release:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Tue 20 Sep 2016 02:35:08 PM UTC, comment #5: 

Pushed the docstring patch here: http://hg.savannah.gnu.org/hgweb/octave/rev/e15b89c4c2dd

Closing as fixed.

Andreas Weber <andy1978>
Group Member
Mon 20 Jun 2016 05:15:42 PM UTC, comment #4: 

Attached please find a patch that updates the docstring of patch.m for the changes made in the other changesets.
I also made slight changes to demo #4 to include the syntax with input mixed between property/value pairs and a structure.

(file #37530)

Markus Mützel <mmuetzel>
Group administrator
Fri 17 Jun 2016 03:21:51 AM UTC, comment #3: 

Let's leave it open until the docstring is fixed, but I've reduced the priority and severity to the minimum.

Lachlan Andrew <lachlan>
Fri 03 Jun 2016 01:40:08 PM UTC, comment #2: 

This bug was resolved with bug #48038 and changeset 1955af16b42e.

The docstring in patch.m could be adapted to reflect that change. But it is probably not worth leaving this bug open only for this.

Markus Mützel <mmuetzel>
Group administrator
Wed 13 Apr 2016 08:08:24 AM UTC, comment #1: 

The function "patch" does not correctly handle mixes of structures and prop/value pairs either which work in Matlab.

This patch completely removes the special handling of struct input in "patch". This resolves this issue and the one described in comment #0 for the default branch (needs changeset 38c0c1f5cf57 for mixes of structures and prop/value pairs).

(file #36916)

Markus Mützel <mmuetzel>
Group administrator
Tue 12 Apr 2016 11:06:40 AM UTC, original submission:  

The function patch supports passing a struct with the fields "faces", "vertices", and optionally "facevertexcdata".
While it is OK for Matlab to mix uppercase and lowercase letters in this fieldnames, Octave only works for lowercase only letters.
A minimal example that works in Matlab but fails in Octave:

p.Vertices = [0, 1; 1, 1; 0, 0];
p.Faces = [1 2 3];
hp = patch (p);


I will try and submit a patch for this soon.

Markus Mützel <mmuetzel>
Group administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #37530:  patch_docstring.patch added by mmuetzel (2KiB - text/x-diff)
file #36916:  bug47672.patch added by mmuetzel (2KiB - text/x-diff)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by andy1978 (Posted a comment)
  • -email is unavailable- added by lachlan (Posted a comment)
  • -email is unavailable- added by mmuetzel (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only group members can vote.

     

    Follow 6 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2016-09-20 andy1978 StatusNone Fixed
        Open/ClosedOpen Closed
    2016-06-20 mmuetzel Attached File- Added patch_docstring.patch, #37530
    2016-06-17 lachlan Severity3 - Normal 1 - Wish
        Priority5 - Normal 1 - Later
    2016-04-13 mmuetzel Attached File- Added bug47672.patch, #36916

    Back to the top

    Powered by Savane 3.13-f8d8.
    Corresponding source code