bugGNU Octave - Bugs: bug #47513, function "uibuttongroup"...

 
 

bug #47513: function "uibuttongroup" not implemented

Submitter:  Ihab <ihab_el_aff>
Submitted:  Wed 23 Mar 2016 09:55:06 PM UTC
   
 
Category:  GUI Severity:  1 - Wish
Priority:  3 - Low Item Group:  Matlab Compatibility
Status:  Fixed Assigned to:  None
Originator Name:  Ihab ELAFF Open/Closed:  * Closed
Release:  * dev Operating System:  * Any
Fixed Release:  None Planned Release:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Jump to the original submission

Sun 05 Jun 2016 08:07:52 PM UTC, comment #14: 

Pulled in changes, works for me.

Mike Miller <mtmiller>
Group Member
Sun 05 Jun 2016 06:56:51 PM UTC, comment #13: 
John Donoghue <lostbard>
Group Member
Sun 05 Jun 2016 04:58:31 PM UTC, comment #12: 

My comment is that I have been silently trying this patch from Andrew Thornton (2nd version from patch #8992) during the last weeks but at a slow pace due to little time, and AFAICS it works OK.
Glad that others tried as well and good that it'll be pushed :-)

Philip Nienhuis <philipnienhuis>
Group Member
Sun 05 Jun 2016 12:44:27 PM UTC, comment #11: 

I will push to default today if noone else has any comments

John Donoghue <lostbard>
Group Member
Fri 20 May 2016 07:44:39 AM UTC, comment #10: 

Glad this is working for you too. Do you need me to make any changes to get this merged?

Anonymous
Tue 17 May 2016 02:47:45 PM UTC, comment #9: 

Works in both Linux and windows for me

I tested with the code in the help and then variants of this:


function test_uibuttongroup

  f = figure();

  bgroup = uibuttongroup(f, ...
                  "title", "Test", ...
                  "position",[0 0 .5 .5],...
                  "BorderType", "etchedout", ...
                  "titleposition", "centertop", ...
                  "selectionchangedfcn",{@buttonselection});

  % Create three radio buttons in the button group.
  uicontrol(bgroup,...
                  "style", "radiobutton",...
                  "string","radiobutton 1",...
                  "position",[10 150 300 30],...
                  "handlevisibility","off");

  uicontrol(bgroup,
                  "style", "radiobutton",...
                  "string","radiobutton 2",...
                  "position",[10 100 300 30],...
                  "handlevisibility","off");

  uicontrol(bgroup,
                  "style", "radiobutton",...
                  "string","radiobutton 3",...
                  "position",[10 50 300 30],...
                  "handlevisibility","off");

  % create menus in the context menu
  c = uicontextmenu (f);
  m1 = uimenu ("parent",c,"label","Menu item 1","callback","disp('menu item 1')");
  set (bgroup, "uicontextmenu", c);

endfunction

function buttonselection(source,callbackdata)
  printf("Previous selection: %s\n", get(callbackdata.OldValue, 'String'));
  printf("New selection: %s\n", get(callbackdata.NewValue, 'String'));
endfunction






John Donoghue <lostbard>
Group Member
Sun 15 May 2016 10:54:09 PM UTC, comment #8: 

Nice!

I can take a look in the next couple of days, unless someone else gets to it first

John Donoghue <lostbard>
Group Member
Sun 15 May 2016 09:08:14 PM UTC, comment #7: 

Attaching a patch from the patch tracker contributed by Andrew Thornton (see patch #8992, now closed as a duplicate).

I did a very brief review of the coding style and it looks quite good to me. I have not yet applied and tested the functionality yet, will comment again when I have a chance to do so.

Any other developers available to take a look at this patch or test it out?

(file #37165)

Mike Miller <mtmiller>
Group Member
Fri 25 Mar 2016 03:26:31 PM UTC, comment #6: 

The solution is someone who is interested writes this function for Octave so we can add it to the official distribution. Can you write uibuttongroup for us? Note that it is not permitted to grab any m-files or other code from any copy of Matlab you may have access to.

If you can't contribute a patch for implementing this function, you'll have to wait for one of the usual developers to be interested or motivated to write this function.

Mike Miller <mtmiller>
Group Member
Fri 25 Mar 2016 08:36:48 AM UTC, comment #5: 

OK
Let's basiclly do it for the function "uibuttongroup". Is there  solution for that?

Ihab <ihab_el_aff>
Thu 24 Mar 2016 02:28:47 PM UTC, comment #4: 

Thanks for following up about this. If fixing these compatibility problems is important to you, the best way to go about it is to report individual bugs with the details of each problem. You can certainly refer to OpenProb in each bug report to keep them straight, but this kind of report (with 3 or more different problems that may be solved independently and on different time frames) is not helpful at all.

Can we pick one specific problem, for example "missing function uibuttongroup"? If you can further identify what are the problems with the set function and the parser, those should be reported independently.

Is it possible for you to work on an implementation of uibuttongroup to help resolve this?

https://www.mathworks.com/help/matlab/ref/uibuttongroup.html

Mike Miller <mtmiller>
Group Member
Thu 24 Mar 2016 12:05:54 PM UTC, comment #3: 

Yes it is. I am also the one whom post this bug

Ihab <ihab_el_aff>
Thu 24 Mar 2016 12:02:07 PM UTC, comment #2: 

I am assuming this same report as bug #47395, but with information attached?

John Donoghue <lostbard>
Group Member
Thu 24 Mar 2016 07:48:13 AM UTC, comment #1: 

I debug the code, it seems that there are 3 problems:

- uibuttongroup function does not exist in Octave
- There are problems with "set" function
- Octave can not see functions as two passes, so calling the function before it is declared is not available.

I am trying to solve the problem, however, i think i need help from Octave developers.


Ihab <ihab_el_aff>
Wed 23 Mar 2016 09:55:06 PM UTC, original submission:  

Hello

The open propeller interface is not running correctly in both Ocatve 4 and 4.1

You can find this GPL software on:
http://engineering.dartmouth.edu/epps/openprop/download.html


Ihab <ihab_el_aff>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #37165:  uibuttongroup.diff added by mtmiller (49KiB - text/x-diff)

 

Carbon-Copy List
  • -email is unavailable- added by mtmiller (Posted a comment)
  • -email is unavailable- added by lostbard (Posted a comment)
  • -email is unavailable- added by ihab_el_aff (Submitted the item)
  • -email is unavailable- added by ihab_el_aff
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only group members can vote.

     

    Follow 14 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2016-06-05 mtmiller StatusReady For Test Fixed
        Open/ClosedOpen Closed
    2016-06-05 lostbard StatusPatch Submitted Ready For Test
    2016-05-15 mtmiller Dependencies- patch #8992 is dependent
    2016-05-15 mtmiller Attached File- Added uibuttongroup.diff, #37165
        StatusNeed Info Patch Submitted
    2016-03-24 mtmiller Severity3 - Normal 1 - Wish
        Priority5 - Normal 3 - Low
        StatusNone Need Info
        Release4.0.1-rc1 dev
        Operating SystemMicrosoft Windows Any
        SummaryOpenProb GUI- running error function "uibuttongroup" not implemented
    2016-03-24 lostbard Dependencies- bugs #47395 is dependent
    2016-03-23 ihab_el_aff Carbon-Copy- Added -email is unavailable-

    Back to the top

    Powered by Savane 3.13-f8d8.
    Corresponding source code