bugGNU Octave - Bugs: bug #47042, [octave forge] (signal) fails to...

 
 

bug #47042: [octave forge] (signal) fails to build with "'gripe_wrong_type_arg' was not declared in this scope"

Submitter:  Philip Nienhuis <philipnienhuis>
Submitted:  Mon 01 Feb 2016 08:53:22 PM UTC
   
 
Category:  Configuration and Build System Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Build Failure
Status:  Fixed Assigned to:  None
Originator Name:  Philip Nienhuis Open/Closed:  * Closed
Release:  * dev Operating System:  * Other
Fixed Release:  None Planned Release:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Jump to the original submission

Wed 30 May 2018 04:42:27 PM UTC, comment #9: 
Markus Mützel <mmuetzel>
Group administrator
Wed 30 May 2018 03:25:42 PM UTC, comment #8: 

Even though the symptom is the same, I would prefer that you file a new bug report because the cause of this error is now different than the original failure.

And I will like to release at least one or two more signal packages before removing backwards compatibility with Octave 4.0.

Mike Miller <mtmiller>
Group Member
Wed 30 May 2018 02:13:45 PM UTC, comment #7: 

This error re-appeared when building with Octave 5.0.

Should of-signal be adapted to use "errwarn.h" instead of "gripes.h" now? (see Rik's comment #6)

Markus Mützel <mmuetzel>
Group administrator
Sun 14 Feb 2016 09:49:21 PM UTC, comment #6: 

I included "gripes.h" in oct.h so that older code will compile correctly (http://hg.savannah.gnu.org/hgweb/octave/rev/e5cf0a9df3a2).  The code in gripes.h is deprecated and it will produced warnings instructing the package maintainer about how to transition to errwarn.h.  In version 4.6 we will remove gripes.h entirely.

I tested installing the signal package and it works for me now so I'm closing this report.

Rik <rik5>
Group administrator
Tue 02 Feb 2016 10:42:16 PM UTC, comment #5: 

Yes, this bug should only manifest with the development version of octave which has switched from including gripes.h to errwarn.h.

Rik <rik5>
Group administrator
Tue 02 Feb 2016 10:05:16 PM UTC, comment #4: 

I haven't cross-built 4.0.1 + OF packages in MXE for some time; but as this bug report seems to be caused by some recent change in dev-octave, I think you are correct.

Philip Nienhuis <philipnienhuis>
Group Member
Tue 02 Feb 2016 09:45:16 PM UTC, comment #3: 

So to be clear, this is about building the signal package for the default branch of Octave? No change is needed to build the package for 4.0.1, correct?

Mike Miller <mtmiller>
Group Member
Tue 02 Feb 2016 08:11:18 PM UTC, comment #2: 

Thanks, that works.

This fix seems to be needed as well for the strings package (pcregexp.cc)

I'll set status to "Confirmed"

Philip Nienhuis <philipnienhuis>
Group Member
Tue 02 Feb 2016 05:35:56 AM UTC, comment #1: 

Try adding


#include "gripes.h"


to the top of


cl2bp.cc
sosfilt.cc
upfirdn.cc


That should work.  Probably for the dev branch of-signal needs to be re-written to use "err_wrong_type_arg".

Rik <rik5>
Group administrator
Mon 01 Feb 2016 08:53:22 PM UTC, original submission:  

After having used my MXE build tree for a month, building new Octave versions with it, I figured it was time to rebuild all OF packages and did:
touch src/of*.mk

control, io, general, and optim built fine, but signal didn't.
From the of-signal log:

:
cl2bp.cc: In function 'octave_value_list Fcl2bp(const octave_value_list&, int)':
cl2bp.cc:87:43: error: 'gripe_wrong_type_arg' was not declared in this scope
     gripe_wrong_type_arg("cl2bp", args (0));

cl2bp.cc:92:43: error: 'gripe_wrong_type_arg' was not declared in this scope
     gripe_wrong_type_arg("cl2bp", args (1));

cl2bp.cc:97:43: error: 'gripe_wrong_type_arg' was not declared in this scope
     gripe_wrong_type_arg("cl2bp", args (2));

cl2bp.cc:102:43: error: 'gripe_wrong_type_arg' was not declared in this scope
     gripe_wrong_type_arg("cl2bp", args (3));

cl2bp.cc:107:43: error: 'gripe_wrong_type_arg' was not declared in this scope
     gripe_wrong_type_arg("cl2bp", args (4));
:
<snip>
:
cl2bp.cc:124:43: error: 'gripe_wrong_type_arg' was not declared in this scope
     gripe_wrong_type_arg("cl2bp", args (5));

Makefile:20: recipe for target 'cl2bp.o' failed


Philip Nienhuis <philipnienhuis>
Group Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Digest:
   bug dependencies.

 

Carbon-Copy List
  • -email is unavailable- added by mmuetzel (Posted a comment)
  • -email is unavailable- added by mtmiller (Posted a comment)
  • -email is unavailable- added by rik5 (Posted a comment)
  • -email is unavailable- added by philipnienhuis (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only group members can vote.

     

    Follow 9 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2019-02-12 mtmiller Dependencies- bugs #55701 is dependent
    2018-05-30 mtmiller StatusConfirmed Fixed
        Open/ClosedOpen Closed
    2018-05-30 mmuetzel StatusFixed Confirmed
        Open/ClosedClosed Open
        Summary[MXE] of-signal fails to build with &quot;'gripe_wrong_type_arg' was not declared in this scope&quot; [octave forge] (signal) fails to build with "'gripe_wrong_type_arg' was not declared in this scope"
    2016-02-14 rik5 StatusConfirmed Fixed
        Open/ClosedOpen Closed
    2016-02-02 philipnienhuis StatusNone Confirmed

    Back to the top

    Powered by Savane 3.13-f8d8.
    Corresponding source code