bugGNU Octave - Bugs: bug #44642, [OF] io package: problem with...

 
 

bug #44642: [OF] io package: problem with xlsread ('fullname')

Submitter:  Avinoam Kalma <avinoam>
Submitted:  Fri 27 Mar 2015 07:24:55 AM UTC
   
 
Category:  Octave Package Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Incorrect Result
Status:  Fixed Assigned to:  philipnienhuis
Originator Name:  Avinoam Open/Closed:  * Closed
Release:  * other Operating System:  * Any
Fixed Release:  None Planned Release:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Mon 25 May 2015 08:46:28 PM UTC, comment #4: 

io-2.2.8 is indeed planned, hopefully before a Windows binary for 4.0.0 is released.
But I don't know when I have time for it. There are a few other issues to be fixed before that time that depend on yet other Octave / MXE bugs. As it happens I'm currently busy investigating the current situation after some backlog :-)

BTW Rik bugged me about that old canonicalize_file_name bug (see bug #36677) that underlies part of this bug report; but I'm not proficient in C++ :-(
I think we have to make do with the resulting limitations.

Philip Nienhuis <philipnienhuis>
Group Member
Mon 25 May 2015 07:24:14 PM UTC, comment #3: 

The fixes were not included in last version (2.2.7) of
io package.

Is it possible to make a new release before Octave 4.0.0
with these fixes?

Avinoam Kalma <avinoam>
Group Member
Sun 29 Mar 2015 01:18:13 PM UTC, comment #2: 

Fixed in this changesets:
http://hg.code.sf.net/p/octave/io/rev/9615795b89aa
http://hg.code.sf.net/p/octave/io/rev/a920f7408781

make_absolute_filename() is required, otherwise things could get mixed up when Octave changes directory while a file is open; not so much in Excel/Java etc but rather in io's own file name logic.

AFAIR the intent of the code must have been to work with files on different drive letters when Octave was started from a cmd32 window (in which case the current dir on another drive letter isn't guaranteed to be the root dir).
But (1) it has never worked reliably and (2) Octave has a GUI or is started from a desktop shortcut.
So I figured just simplifying the code would be OK.

Philip Nienhuis <philipnienhuis>
Group Member
Fri 27 Mar 2015 02:17:08 PM UTC, comment #1: 

This is probably related to a very old issue: see bug #36677

It may be that in the call in  _COM__spsh_open_.m neither make_absolute_filename nor canonicalize_file_name are required at all.
At the time of bug #36677 I tried that but in some cases (which ones it were escaped me, it's a while back) things went wrong.

Perhaps I got time this weekend to have another look into it.

Thanks for noticing.

Philip Nienhuis <philipnienhuis>
Group Member
Fri 27 Mar 2015 07:24:55 AM UTC, original submission:  


if current directory is c:\dir1,
xlsread ('c:\dir2\a.xlsx') failes because of


      filename = make_absolute_filename (strsplit (filename, filesep){end});


in __COM__spsh_open__.m   that changes filename to c:\dir1\a.xlsx

The code


      if (!is_absolute_filename)
        filename = make_absolute_filename (strsplit (filename, filesep){end});
      endif


solve this, but it doesn't solve usage of relative path, like

xlsread ('..\dir2\a.xlsx')


Avinoam Kalma <avinoam>
Group Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by avinoam (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only group members can vote.

     

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2015-03-29 philipnienhuis StatusNone Fixed
        Open/ClosedOpen Closed
    2015-03-27 philipnienhuis Assigned toNone philipnienhuis
        Release4.0.0-rc2 other

    Back to the top

    Powered by Savane 3.13-d3ae.
    Corresponding source code