bugGNU Octave - Bugs: bug #66766, [octave-forge] signal package...

 
 

bug #66766: [octave-forge] signal package -> Missing function sos2cell ( patch )

Submitter:  Abinash Singh <abinashsingh>
Submitted:  Sat 08 Feb 2025 07:27:30 PM UTC
   
 
Category:  Octave Package Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Feature Request
Status:  Fixed Assigned to:  None
Originator Name:  Abinash Singh Open/Closed:  * Closed
Release:  * 9.4.0 Release: 
Operating System:  * Any Fixed Release:  None
Planned Release:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Tue 01 Apr 2025 12:01:26 PM UTC, comment #3: 

I added the patch - thanks!.

I did have to change a couple of things in the texinfo - for the cell examples the { and } need pre prepended with @.

ie: @{ 1, 2, 3 @}


It should be in the next release of signal.

John Donoghue <lostbard>
Group Member
Sun 30 Mar 2025 05:49:26 PM UTC, comment #2: 

Thanks for the feedback, John!

I've updated the patch to address your comments:

Fixed the texinfo documentation formatting by ensuring all lines start with ##.

Added test cases at the end of the file to validate sos2cell functionality.

Included a reference to sos2cell in the Filter Conversion section of the INDEX file.

Please review the updated patch and let me know if any further changes are needed.

(file #57083)

Abinash Singh <abinashsingh>
Sat 22 Feb 2025 02:53:16 PM UTC, comment #1: 

Thanks for the patch!

I took a quick look at the patch and have a few comments:

1. The textinfo section has empty non comment lines between parts of the documentation, so the texinfo section will stop at those blank lines.  You should keep the lines in the text info section as lines sarrting with ##

2. You should include some tests as well at the end of the file

3. The INDEX file should include a reference to the new function - in the Filter Conversion section ?

John Donoghue <lostbard>
Group Member
Sat 08 Feb 2025 07:27:30 PM UTC, original submission:  

This patch implements sos2cell function which was under the "missing function" category.

source: https://wiki.octave.org/Signal_package

Please review it and provide me feedback. I'm also working on its inverse i.e cell2sos

Thank You

Abinash Singh <abinashsingh>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #57083:  sos2cell_v1.patch added by abinashsingh (6KiB - text/x-patch)
file #56863:  sos2cell.patch added by abinashsingh (3KiB - text/x-patch - Please provide me feedback for improvements)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by lostbard (Posted a comment)
  • -email is unavailable- added by nrjank (Updated the item)
  • -email is unavailable- added by abinashsingh (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only group members can vote.

     

    Follow 5 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2025-04-01 lostbard StatusPatch Submitted Fixed
        Open/ClosedOpen Closed
    2025-03-30 abinashsingh Attached File- Added sos2cell_v1.patch, #57083
    2025-02-08 nrjank StatusNone Patch Submitted
    2025-02-08 abinashsingh Attached File- Added sos2cell.patch, #56863

    Back to the top

    Powered by Savane 3.14-962f.
    Corresponding source code