bugGNU Octave - Bugs: bug #66264, (communications) ov-galois.cc...

 
 

bug #66264: (communications) ov-galois.cc needs to #include <cassert>

Submitter:  Dmitri A. Sergatskov <dasergatskov>
Submitted:  Fri 27 Sep 2024 04:08:37 PM UTC
   
 
Category:  Octave Package Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Build Failure
Status:  Fixed Assigned to:  None
Originator Name:  Open/Closed:  * Closed
Release:  * dev Release: 
Operating System:  * Any Fixed Release:  None
Planned Release:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Thu 20 Feb 2025 08:11:32 AM UTC, comment #3: 

Afaict, communications 1.2.7 (2025-01-30) should be containing a fix for this issue.
Thanks for the pointer.

Closing report.

Markus Mützel <mmuetzel>
Group administrator
Thu 20 Feb 2025 05:58:24 AM UTC, comment #2: 

Can be closed.

Dmitri.
--

Dmitri A. Sergatskov <dasergatskov>
Fri 27 Sep 2024 04:14:47 PM UTC, comment #1: 

I see Markus has already made this change in hg. So it needs new release.

Dmitri.
--

Dmitri A. Sergatskov <dasergatskov>
Fri 27 Sep 2024 04:08:37 PM UTC, original submission:  

Installing "communications" on octave 10, I see:

g++ -std=gnu++17 -c  -fPIC -I/usr/local/include/octave-10.0.0/octave/.. -I/usr/local/include/octave-10.0.0/octave -I/usr/local/include  -pthread -fopenmp -ggdb3 -O2 -march=native -mtune=native -mavx -mavx2 -flto=auto    -DGALOIS_DISP_PRIVATES -DHAVE_CONFIG_H syndtable.cc -o /tmp/oct-dQTWRw.o
ov-galois.cc: In member function ‘octave_value_list octave_galois::dotref(const octave_value_list&)’:
ov-galois.cc:97:3: error: ‘assert’ was not declared in this scope
   97 |   assert (idx.length () == 1);
      |   ^~~~~~
ov-galois.cc:54:1: note: ‘assert’ is defined in header ‘<cassert>’; did you forget to ‘#include <cassert>’?
   53 | #include "ov-galois.h"
  +++ |+#include <cassert>
   54 |


In octave 10.x #include <cassert> was removed from octave's header files. So if external code requires <cassert> it needs to include it explicitly.

Dmitri.
--

Dmitri A. Sergatskov <dasergatskov>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by mmuetzel (Posted a comment)
  • -email is unavailable- added by dasergatskov (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only group members can vote.

     

    Follow 2 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2025-02-20 mmuetzel StatusNone Fixed
        Open/ClosedOpen Closed

    Back to the top

    Powered by Savane 3.15-26b0.
    Corresponding source code