bugGNU Octave - Bugs: bug #65528, (nurbs) should include...

 
 

bug #65528: (nurbs) should include <cassert>

Submitter:  Dmitri A. Sergatskov <dasergatskov>
Submitted:  Thu 28 Mar 2024 07:11:40 PM UTC
   
 
Category:  Octave Package Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Build Failure
Status:  Patch Submitted Assigned to:  None
Originator Name:  Open/Closed:  * Open
Release:  * dev Release: 
Operating System:  * Any Fixed Release:  None
Planned Release:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Jump to the original submission

Tue 11 Feb 2025 01:35:52 AM UTC, comment #11: 

@cdf no objection from me if you want to move the repository to another platform that's more convenient

Nir Krakauer <nir_krakauer>
Mon 10 Feb 2025 04:41:06 PM UTC, comment #10: 

Hi Nir, thanks for applying the patch and making the new release.

I am listed as one of the maintainers, it would be OK for me to
keep taking care of the package but I think I lost my SF
credentials, so Id probably prefer to move the main repo on some
other platform, any objections?


Carlo de Falco <cdf>
Group Member
Mon 10 Feb 2025 03:12:12 PM UTC, comment #9: 

Works for me on MacOS.
Also wrt comment 4:
https://independent.academia.edu/EtienneGrossmann

Dmitri.
--

Dmitri A. Sergatskov <dasergatskov>
Mon 10 Feb 2025 02:40:10 PM UTC, comment #8: 

OK, I made a new release 1.4.4

Nir Krakauer <nir_krakauer>
Mon 10 Feb 2025 02:21:00 PM UTC, comment #7: 

That makes much more sense. I'll fix that in the makefile and then upload the release.

Nir Krakauer <nir_krakauer>
Mon 10 Feb 2025 02:04:46 PM UTC, comment #6: 

Thank you for looking into this.

Do I understand correctly, that the new tarball would contain some .oct files?
Afaict, the current tarball for the nurbs package only contains the sources (not the built .oct files). The .oct files are platform dependent and should be built by Octave when installing the package.

Markus Mützel <mmuetzel>
Group administrator
Mon 10 Feb 2025 01:59:41 PM UTC, comment #5: 

I updated the repo with the patch now. I'm puzzled though by why my compiled .oct files are a couple MB each, resulting in a 9.2 MB generated tarball. Is this expected behavior, or am I missing a setting? The 1.4.3 tarball is only 124 KB

Nir Krakauer <nir_krakauer>
Mon 10 Feb 2025 01:16:31 PM UTC, comment #4: 

Thank you, Nir. That would be very nice.

I hope this isn't pushing it: But while you are at it, could you please also help Etienne in bug #66705 and make a new release of the VRML package for her?

Markus Mützel <mmuetzel>
Group administrator
Mon 10 Feb 2025 01:02:06 PM UTC, comment #3: 

If the maintainers are not responsive, I could commit the patch and make a new release

Nir Krakauer <nir_krakauer>
Mon 10 Feb 2025 07:47:42 AM UTC, comment #2: 

We are now in the process of preparing the release of Octave 10.
With that version of Octave, the nurbs package won't compile any longer until this bug is fixed. (E.g., by merging the patch from MXE Octave.)

Markus Mützel <mmuetzel>
Group administrator
Thu 28 Mar 2024 07:24:28 PM UTC, comment #1: 

CC'ing package maintainers.

The attached patch makes it compile in MXE Octave:
https://hg.octave.org/mxe-octave/file/tip/src/of-nurbs-1-cassert.patch

(file #55896)

Markus Mützel <mmuetzel>
Group administrator
Thu 28 Mar 2024 07:11:40 PM UTC, original submission:  

Compiling on Octave 10 (dev):

/usr/local/bin/mkoctfile-10.0.0 --verbose -c low_level_functions.cc
g++ -std=gnu++17 -c  -fPIC -I/usr/local/include/octave-10.0.0/octave/.. -I/usr/local/include/octave-10.0.0/octave -I/usr/local/include  -pthread -fopenmp -ggdb3 -O2 -march=native -mtune=native -mavx -mavx2 -flto=auto    low_level_functions.cc -o low_level_functions.o
low_level_functions.cc: In function ‘int surfderivcpts(octave_idx_type, octave_idx_type, const RowVector&, octave_idx_type, octave_idx_type, const RowVector&, const Matrix&, octave_idx_type, octave_idx_type, octave_idx_type, octave_idx_type, octave_idx_type, NDArray&)’:
low_level_functions.cc:292:15: error: ‘assert’ was not declared in this scope
  292 |               assert (k<idxa(0) && i<idxa(2) && j-s1<idxa(3));
      |               ^~~~~~
low_level_functions.cc:23:1: note: ‘assert’ is defined in header ‘<cassert>’; did you forget to ‘#include <cassert>’?
   22 | #include <iostream>
  +++ |+#include <cassert>
   23 |
low_level_functions.cc:320:19: error: ‘assert’ was not declared in this scope
  320 |                   assert (k<idxa(0) && l<idxa(1)
      |                   ^~~~~~
low_level_functions.cc:320:19: note: ‘assert’ is defined in header ‘<cassert>’; did you forget to ‘#include <cassert>’?
make: *** [Makefile:34: low_level_functions.o] Error 1
make: Leaving directory '/tmp/oct-blKnTZ/nurbs-1.4.3/src'


The mxe-octave patch is:
https://hg.octave.org/mxe-octave/rev/ebdff9919577

Discussion:

https://octave.discourse.group/t/assert-panic-error-and-ndebug/5409/20

Dmitri.
--



Dmitri A. Sergatskov <dasergatskov>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by cdf (Posted a comment)
  • -email is unavailable- added by nir_krakauer (Posted a comment)
  • -email is unavailable- added by mmuetzel (Updated the item)
  • -email is unavailable- added by mmuetzel
  • -email is unavailable- added by mmuetzel
  • -email is unavailable- added by dasergatskov (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only group members can vote.

     

    Follow 5 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2024-03-28 mmuetzel Attached File- Added of-nurbs-1-cassert.patch, #55896
        Item GroupNone Build Failure
        StatusNone Patch Submitted
        Carbon-Copy- Added cdf
        Carbon-Copy- Added rafavzqz

    Back to the top

    Powered by Savane 3.14-7003.
    Corresponding source code