bugGNU Octave - Bugs: bug #64276, [octave forge] (signal) Unit test...


bug #64276: [octave forge] (signal) Unit test of firpm fails on ppc64el architecture

Submitter:  Rafael Laboissière <rlaboiss>
Submitted:  Sat 03 Jun 2023 06:07:51 AM UTC
Category:  Octave Forge Package Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Unexpected Error or Warning
Status:  Fixed Assigned to:  lostbard
Originator Name:  Open/Closed:  * Closed
Release:  * other Operating System:  * GNU/Linux
Fixed Release:  None Planned Release:  None
* Mandatory Fields

Add a New Comment Rich Markup

Mon 05 Jun 2023 12:34:24 PM UTC, comment #4: 

I pushed a change to check for error code 4, 5 or 6

John Donoghue <lostbard>
Group Member
Sun 04 Jun 2023 04:52:19 PM UTC, comment #3: 

I see on aarch64:

octave:3> pkg load signal
octave:4> firpm (2, [.1 .9], 1)
error: firpm failed to make a filter (result=6)
octave:5> ver
GNU Octave Version: 8.2.1 (hg id: 73720920057e)
GNU Octave License: GNU General Public License
Operating System: Linux 6.3.5-200.fc38.aarch64 #1 SMP PREEMPT_DYNAMIC Tue May 30 16:06:05 UTC 2023 aarch64
Package Name  | Version | Installation directory
     control *|   3.6.0 | /home/dima/.local/share/octave/api-v58/packages/control-3.6.0
      signal *|   1.4.4 | /home/dima/.local/share/octave/api-v58/packages/signal-1.4.4



Dmitri A. Sergatskov <dasergatskov>
Sun 04 Jun 2023 04:13:46 PM UTC, comment #2: 

This test deliberately invokes convergence failure, to check that the error is reported correctly.

There are three different ways that failure-to-converge can be detected and it seems that which one occurs first in this example is architecture dependent. I’d seen 4 occur on x86-64, then 6 on ARM-32, and now we have 5 on ppc64el.

So I think that the fix should be to extend the wild-card [46] to all 3 values i.e. [456].

Rob Sykes <robsykes>
Sun 04 Jun 2023 10:40:44 AM UTC, comment #1: 

The first patch changed the value from

-%!error <firpm failed to make a filter \(result=4\)> firpm (2, [.1 .9], 1);
+%!error <firpm failed to make a filter \(result=[46]\)> firpm (2, [.1 .9], 1);

Which when run on my computer, passes ok

However if I run the command  firpm (2, [.1 .9], 1);

The result is  firpm failed to make a filter (result=4)

John Donoghue <lostbard>
Group Member
Sat 03 Jun 2023 06:07:51 AM UTC, original submission:  

We have put together a Debian package for version 1.4.4 of the signal package. It failed to build from source on many of the official architectures of Debian (namely arm64, armel, armhf, mips64el, mipsel, ppc64el, and s390x), due to problems in running the firpm unit tests.

After applying the proposed patch #10351 (actually, taken from commits 5ca9186 and 3f009c9), things improved, but one unit test is still failing on the ppc64el architecture (full log) with
the following error message:

***** error <firpm failed to make a filter \(result=[46]\)> firpm (2, [.1 .9], 1);
!!!!! error failed.
Expected <firpm failed to make a filter \(result=[46]\)>, but got <firpm failed to make a filter (result=5)>

Does anyone have a clue about what is causing this?

Rafael Laboissière <rlaboiss>


(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:

No files currently attached


Depends on the following items: None found

Items that depend on this one: None found


Carbon-Copy List
  • -email is unavailable- added by dasergatskov (Posted a comment)
  • -email is unavailable- added by robsykes (Posted a comment)
  • -email is unavailable- added by lostbard (Posted a comment)
  • -email is unavailable- added by lostbard (adding script author)
  • -email is unavailable- added by rlaboiss (Submitted the item)

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only project members can vote.


    Follow 5 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2023-06-27 lostbard StatusReady For Test Fixed
        Assigned toNone lostbard
        Open/ClosedOpen Closed
    2023-06-05 lostbard StatusNone Ready For Test
    2023-06-03 lostbard Carbon-Copy- Added robsykes

    Back to the top

    Powered by Savane 3.12